Re: [PATCH 1/5] dt-bindings: arm: altera: fix Agilex72 compatible vendor prefix

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Critical] Destructive removal of device tree compatible strings breaks ABI and schema validation.
--

--- Patch [1]: [PATCH 1/5] dt-bindings: arm: altera: fix Agilex72 compatible vendor prefix ---
commit 7bb728799feb3a9be3367a121312b26bbd930632
Author: Chiam, Evon <evon.chiam@altera.com>

dt-bindings: arm: altera: fix Agilex72 compatible vendor prefix

Altera has separated from Intel. Update the Agilex72 SoC and board
compatible strings to use the Altera vendor prefix instead of intel.

> diff --git a/Documentation/devicetree/bindings/arm/altera.yaml b/Documentation/devicetree/bindings/arm/altera.yaml
> index 3030cf46fe74c..2ab53cade2fe4 100644
> --- a/Documentation/devicetree/bindings/arm/altera.yaml
> +++ b/Documentation/devicetree/bindings/arm/altera.yaml
> @@ -119,8 +119,8 @@ properties:
>        - description: Agilex72 boards
>          items:
>            - enum:
> -              - intel,socfpga-agilex72-socdk
> -          - const: intel,socfpga-agilex72
> +              - altr,socfpga-agilex72-socdk
> +          - const: altr,socfpga-agilex72

[Severity: Critical]
Does replacing these compatible strings completely rather than retaining the
older strings as deprecated break the ABI for existing bootloaders or
firmware?

Also, will this omission cause validation failures during make dtbs_check?

Looking at the tree, arch/arm64/boot/dts/intel/socfpga_agilex72.dtsi still
uses the removed string:

arch/arm64/boot/dts/intel/socfpga_agilex72.dtsi:

    / {
        compatible = "intel,socfpga-agilex72";

and arch/arm64/boot/dts/intel/socfpga_agilex72_socdk.dts also continues to
use the removed strings:

arch/arm64/boot/dts/intel/socfpga_agilex72_socdk.dts:

    / {
        model = "Altera SoCFPGA Agilex72 SoCDK";
        compatible = "intel,socfpga-agilex72-socdk", "intel,socfpga-agilex72";

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1786006669.git.evon.chiam@altera.com?part=1