Re: [PATCH 1/4] dt-bindings: rtc: Add NXP PCF8525 RTC

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The `interrupt-names` schema strictly requires the first interrupt to be `inta`, incorrectly rejecting a configuration where only a single `intb` interrupt is connected.
--

--- Patch [1]: [PATCH 1/4] dt-bindings: rtc: Add NXP PCF8525 RTC ---
commit edd4cb5090a8c1765775edd3168f097a2f181903
Author: Shiv Prakash Gupta <shivprakash.gupta@nxp.com>

dt-bindings: rtc: Add NXP PCF8525 RTC

This commit adds a Devicetree binding for the NXP PCF8525 I2C RTC. It
describes optional inta and intb interrupts alongside properties for
external crystal load capacitance and temperature-compensation crystal
models.

> diff --git a/Documentation/devicetree/bindings/rtc/nxp,pcf8525.yaml b/Documentation/devicetree/bindings/rtc/nxp,pcf8525.yaml
> new file mode 100644
> index 0000000000000..bee71ec3da808
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/rtc/nxp,pcf8525.yaml

[ ... ]

> +  interrupts:
> +    minItems: 1
> +    maxItems: 2
> +    description:
> +      INTA, followed by INTB when both interrupt outputs are connected.
> +
> +  interrupt-names:
> +    minItems: 1
> +    items:
> +      - const: inta
> +      - const: intb

[Severity: Medium]
Will this strictly require the first interrupt to be inta, rejecting a
configuration where only a single intb interrupt is connected?

If a board designer creates a device tree node with a single interrupt and
sets interrupt-names to intb, the schema's items list imposes strict
positional constraints requiring the first element to be inta. This would
cause validation to fail for a valid hardware configuration where only the
intb pin is connected.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260807082855.3762394-1-shivprakash.gupta@nxp.com?part=1