Devicetree
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: mohit.dsor@oss.qualcomm.com
Cc: robh@kernel.org, conor+dt@kernel.org,
	dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v10 1/2] dt-bindings: bridge: Add Lontium LT9611C(EX/UXD) MIPI DSI to HDMI driver
Date: Sat, 08 Aug 2026 08:14:00 +0000	[thread overview]
Message-ID: <20260808081401.3C0841F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260808-lt9611c-v7-v10-1-ee90a136d82a@oss.qualcomm.com>

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Low] The binding title inaccurately describes all variants as '2 Port', despite the newly added LT9611C being a 1-port device.
- [Low] The commit message contains a typo that changes the meaning and makes the sentence difficult to understand: 'Receiver signal/dual port' instead of 'receives single/dual port'.
--

--- Patch [1]: [PATCH v10 1/2] dt-bindings: bridge: Add Lontium LT9611C(EX/UXD) MIPI DSI to HDMI driver ---
commit 289235c0c9457d9357c713f43f18d3182cc0f7d7
Author: Sunyun Yang <syyang@lontium.com>

dt-bindings: bridge: Add Lontium LT9611C(EX/UXD) MIPI DSI to HDMI driver

This commit updates the Lontium LT9611 bridge bindings to add support for
the LT9611C, LT9611EX, and LT9611UXD variants. It adds the new compatible
strings and enforces a single-port configuration specifically for the LT9611C.

> LT9611C(EX/UXD) is an I2C-controlled chip that Receiver signal/dual port
> mipi dsi and output hdmi, differences in hardware features:

[Severity: Low]
This isn't a bug, but there appear to be a few typos in this description.
Would it be clearer to rephrase "Receiver signal/dual port" to "receives
single/dual port"?

> diff --git a/Documentation/devicetree/bindings/display/bridge/lontium,lt9611.yaml b/Documentation/devicetree/bindings/display/bridge/lontium,lt9611.yaml
> index 429a06057ae85..194aeaac601f3 100644
> --- a/Documentation/devicetree/bindings/display/bridge/lontium,lt9611.yaml
> +++ b/Documentation/devicetree/bindings/display/bridge/lontium,lt9611.yaml
> @@ -4,19 +4,23 @@
>  $id: http://devicetree.org/schemas/display/bridge/lontium,lt9611.yaml#
>  $schema: http://devicetree.org/meta-schemas/core.yaml#
>  
> -title: Lontium LT9611(UXC) 2 Port MIPI to HDMI Bridge
> +title: Lontium LT9611(UXC/C/EX/UXD) 2 Port MIPI DSI to HDMI Bridge

[Severity: Low]
This isn't a bug, but does the "2 Port" descriptor still apply to all the
variants listed here? 

Since the LT9611C is described in the commit message as a 1-port device and
its second port is correctly disabled later in this schema, retaining "2 Port"
in the overall title might cause some confusion.

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260808-lt9611c-v7-v10-0-ee90a136d82a@oss.qualcomm.com?part=1

  reply	other threads:[~2026-08-08  8:14 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-08  8:07 [PATCH v10 0/2] Subject: Add Lontium LT9611C(EX/UXD) MIPI DSI to HDMI driver mohit.dsor
2026-08-08  8:07 ` [PATCH v10 1/2] dt-bindings: bridge: " mohit.dsor
2026-08-08  8:14   ` sashiko-bot [this message]
2026-08-08  8:07 ` [PATCH v10 2/2] drm/bridge: " mohit.dsor
2026-08-08  8:27   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260808081401.3C0841F000E9@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=mohit.dsor@oss.qualcomm.com \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox