Re: [PATCH v8 3/9] remoteproc: qcom: pas: add support for TMD thermal cooling devices

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Building `QCOM_Q6V5_PAS` as built-in (`=y`) when `NET` is a module (`=m`) causes a linkage error due to `QCOM_QMI_TMD` being selected as a module.
--

--- Patch [3]: [PATCH v8 3/9] remoteproc: qcom: pas: add support for TMD thermal cooling devices ---
commit f374931389bff4c40d7d760a4a7f08dbd2d99fe0
Author: Gaurav Kohli <gaurav.kohli@oss.qualcomm.com>

remoteproc: qcom: pas: add support for TMD thermal cooling devices

Register Thermal Mitigation Devices (TMDs) for PAS-managed remote processors
to enable thermal throttling through QMI. This allows the thermal framework
to request mitigation when remote subsystems such as modem and CDSP
contribute to thermal pressure.

> diff --git a/drivers/remoteproc/Kconfig b/drivers/remoteproc/Kconfig
> index 5b56b2dcc725f..8501bb108c739 100644
> --- a/drivers/remoteproc/Kconfig
> +++ b/drivers/remoteproc/Kconfig
> @@ -238,6 +238,7 @@ config QCOM_Q6V5_PAS
>  	select QCOM_PIL_INFO
>  	select QCOM_MDT_LOADER
>  	select QCOM_Q6V5_COMMON
> +	select QCOM_QMI_TMD if NET

[Severity: Low]
Could this selection cause a linker error when CONFIG_QCOM_Q6V5_PAS is
built-in (=y) and CONFIG_NET is a module (=m)?

If configured this way, QCOM_QMI_TMD will be selected as a module. Because
IS_ENABLED(CONFIG_QCOM_QMI_TMD) evaluates to true for modules, the header
provides function declarations rather than static inline stubs. The built-in
driver will then attempt to link against the qmi_tmd_init symbol located in
a module, resulting in a build failure.

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260809-b4-qmi-tmd-v8-0-b15d47adc379@oss.qualcomm.com?part=3