From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CCEAA199E89 for ; Sun, 9 Aug 2026 13:30:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786282253; cv=none; b=Djf+jNOr4s1dw/j2nkoYKfoeLvfAe71OhBEK+JhP5Z61yMU5SB338LQCok7mfZ/M7tp3YSUbguZIPRFHxNRW7dU/zySljutI6wiVW5+07octWQApjdHbEnXdJpIlCvZDRV0vjgL6ldMYELWrALpXNxKM6HjYFVWlms6Ko7o0vWw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786282253; c=relaxed/simple; bh=ewcnqsKXFAAf0y5Mcz0DO8N2p6c+Bw2Fi1dtsSgbM/A=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=sVClXN+iG7wdQax22FWjvdAAiMaOOA/T9jO0NK+uRQg13g9xLwzMfj/MKIstG85cavOCMcP0V6wAVzY5/Nz7ZcigyeuRsaPKpUC89WoAWveskjpGtEsYcB+Zcj9ieItSfmCcSkhpz+JCbJLYK0J5Xi765ixa3BEumMVl6hVw2Rk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=c47ZoYqw; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="c47ZoYqw" Received: by smtp.kernel.org (Postfix) with ESMTPSA id EEA231F000E9; Sun, 9 Aug 2026 13:30:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1786282252; bh=YOIZYT1JUWE6dmJnBVuVCrZihRjIkZn2PProRU6Gvwg=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=c47ZoYqwx5Rfc89PGY+LxIUiWlyv6XrR5lwtwp4l713cFGVFLSzzf0eHssMIm1rSn bLIgGn/IDqU5xTwSS6YwEyMShO97uhunVr07nKhZNpocuBf2Mczw7vpl74w7tyvYE9 MsWKaRpNmqjyLW+QWRVaSbAB309zaaFkg0B8ylOs07gv3HpsukP3jBLe0W029cfmu/ OkxYuw7Ob8LLGSgzWkvsXRyBo8SeAF4anTrpToBATuNrZGHd7Hcf1n8T3R8u4hB/0s atlSUvzikW+7SWbg4APV1l9fY20OH0mFbDIsoZu3hBSvwAWnITMh236bxwEXMDYm5C cEi/XMcfS40ZA== From: sashiko-bot@kernel.org Subject: Re: [PATCH v2 15/17] riscv: dts: spacemit: k3-pico-itx: enable the DisplayPort output Reply-To: sashiko-reviews@lists.linux.dev To: "Cody Kang" Cc: robh@kernel.org, devicetree@vger.kernel.org, vkoul@kernel.org, conor+dt@kernel.org, neil.armstrong@linaro.org, linux-phy@lists.infradead.org, dri-devel@lists.freedesktop.org, olteanv@gmail.com In-Reply-To: <20260809-k3-display-v2-15-327d7910bf71@gmail.com> References: <20260809-k3-display-v2-0-327d7910bf71@gmail.com> <20260809-k3-display-v2-15-327d7910bf71@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Sun, 09 Aug 2026 13:30:51 +0000 Message-Id: <20260809133051.EEA231F000E9@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [Low] Missing `dp-connector` node and `remote-endpoint` link for the exte= rnal DisplayPort output, leaving the `dp1_out` graph endpoint disconnected. -- --- Patch [15]: [PATCH v2 15/17] riscv: dts: spacemit: k3-pico-itx: enable = the DisplayPort output --- commit 524eda119bdbf5fa2382226e4f89b196aad432d5 Author: Cody Kang riscv: dts: spacemit: k3-pico-itx: enable the DisplayPort output This commit enables the second DPU and the associated DisplayPort controller to provide output to the external DisplayPort connector on the Pico-ITX boa= rd. > diff --git a/arch/riscv/boot/dts/spacemit/k3-pico-itx.dts b/arch/riscv/bo= ot/dts/spacemit/k3-pico-itx.dts > index b89c1521e6649..6c31460990a75 100644 > --- a/arch/riscv/boot/dts/spacemit/k3-pico-itx.dts > +++ b/arch/riscv/boot/dts/spacemit/k3-pico-itx.dts [ ... ] > @@ -221,3 +222,13 @@ hub@1 { > &usb2_phy { > status =3D "okay"; > }; > + > +&dpu1_crtc0 { > + status =3D "okay"; > +}; > + > +&dp1 { > + pinctrl-names =3D "default"; > + pinctrl-0 =3D <&dp1_1_cfg>; > + status =3D "okay"; > +}; [Severity: Low] Does this device tree need a dp-connector node and a remote-endpoint link=20 for the external DisplayPort output? Since dp1 is enabled here without describing the physical downstream connec= tor=20 or linking it to the output port, it appears to leave the dp1_out graph=20 endpoint disconnected. Even though the display driver might handle this missing topology gracefull= y=20 by falling back to an internal connector initialization, could this omissio= n=20 trigger dtbs_check graph warnings for the dangling endpoint? --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260809-k3-display= -v2-0-327d7910bf71@gmail.com?part=3D15