Devicetree
 help / color / mirror / Atom feed
From: Per Larsson <per@palvencia.se>
To: Andre Przywara <andre.przywara@arm.com>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S . Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Chen-Yu Tsai <wens@kernel.org>,
	Jernej Skrabec <jernej.skrabec@gmail.com>,
	Samuel Holland <samuel@sholland.org>,
	Heiner Kallweit <hkallweit1@gmail.com>,
	Russell King <linux@armlinux.org.uk>,
	Liu Changjie <liucj1228@outlook.com>,
	netdev@vger.kernel.org, devicetree@vger.kernel.org,
	linux-sunxi@lists.linux.dev,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 6/6] arm64: dts: allwinner: a523: x96qpro+: enable Ethernet support
Date: Sun, 9 Aug 2026 13:46:07 +0200	[thread overview]
Message-ID: <20260809134607.65d66069@rpi> (raw)
In-Reply-To: <20260803101452.2993721-7-andre.przywara@arm.com>

On Mon,  3 Aug 2026 12:14:52 +0200
Andre Przywara <andre.przywara@arm.com> wrote:

>  
> +&mdio1 {
> +	ext_rgmii_phy: ethernet-phy@1 {
> +		compatible = "ethernet-phy-id7b74.4411";
> +		reg = <1>;
> +		clocks = <&ccu CLK_EMAC1_25M>;
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&ephy_25m_pin>;

This should be &ephy1_25m_pin, right?

> +		reset-gpios = <&pio 9 16 GPIO_ACTIVE_LOW>;
> +		reset-assert-us = <10000>;
> +		reset-deassert-us = <150000>;
> +	};
> +};
> +
>  &mmc0 {
>  	vmmc-supply = <&reg_vcc3v3>;
>  	cd-gpios = <&pio 5 6 (GPIO_ACTIVE_LOW | GPIO_PULL_UP)>; /*
> PF6 */


      parent reply	other threads:[~2026-08-09 11:46 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-03 10:14 [PATCH 0/6] sunxi: net: add Ethernet support for X96QPro+ Andre Przywara
2026-08-03 10:14 ` [PATCH 1/6] net: phy: maxio: prepare for more DT properties Andre Przywara
2026-08-04  2:42   ` Andrew Lunn
2026-08-03 10:14 ` [PATCH 2/6] net: phy: maxio: parse and enable PHY clock from generic DT binding Andre Przywara
2026-08-04  2:43   ` Andrew Lunn
2026-08-03 10:14 ` [PATCH 3/6] dt-bindings: net: Maxio PHY: add PHY-ID for -Q2C variant Andre Przywara
2026-08-03 10:14 ` [PATCH 4/6] net: phy: maxio: extend PHY ID matching Andre Przywara
2026-08-03 14:59   ` Per Larsson
2026-08-04  2:49   ` Andrew Lunn
2026-08-03 10:14 ` [PATCH 5/6] arm64: dts: allwinner: a523: add EPHY 25MHz clock fanout pins Andre Przywara
2026-08-03 10:14 ` [PATCH 6/6] arm64: dts: allwinner: a523: x96qpro+: enable Ethernet support Andre Przywara
2026-08-04  2:53   ` Andrew Lunn
2026-08-04  3:11     ` Chen-Yu Tsai
2026-08-04 14:44       ` Andrew Lunn
2026-08-09 11:46   ` Per Larsson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260809134607.65d66069@rpi \
    --to=per@palvencia.se \
    --cc=andre.przywara@arm.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=conor+dt@kernel.org \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=edumazet@google.com \
    --cc=hkallweit1@gmail.com \
    --cc=jernej.skrabec@gmail.com \
    --cc=krzk+dt@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-sunxi@lists.linux.dev \
    --cc=linux@armlinux.org.uk \
    --cc=liucj1228@outlook.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=robh@kernel.org \
    --cc=samuel@sholland.org \
    --cc=wens@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox