Re: [PATCH 1/4] dt-bindings: display: panel: Document 10" Raspberry Pi Touch Display 2

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Incorrect use of `additionalProperties: false` when inheriting from a common schema via `allOf`.
--

--- Patch [1]: [PATCH 1/4] dt-bindings: display: panel: Document 10" Raspberry Pi Touch Display 2 ---
commit 24ac9b0c966cb6294b25fc745f5c098627bda264
Author: Marek Vasut <marek.vasut+renesas@mailbox.org>
Date:   Sun Aug 9 19:58:50 2026 +0000

dt-bindings: display: panel: Document 10" Raspberry Pi Touch Display 2

This commit documents the 10" Raspberry Pi Touch Display 2 MIPI-DSI TFT LCD
panel based on the Ilitek ILI79600A controller.

> diff --git a/Documentation/devicetree/bindings/display/panel/ilitek,ili79600a.yaml b/Documentation/devicetree/bindings/display/panel/ilitek,ili79600a.yaml
> new file mode 100644
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/ilitek,ili79600a.yaml
[ ... ]
> +allOf:
> +  - $ref: panel-common.yaml#
> +
> +properties:
[ ... ]
> +  backlight: true
> +
> +required:
> +  - compatible
> +  - reg
> +
> +additionalProperties: false

[Severity: Medium]
Should this use unevaluatedProperties: false instead?

Because this binding inherits from panel-common.yaml# in the allOf block,
using additionalProperties: false will cause the schema to reject any valid
inherited properties (such as rotation or port) when evaluating a device tree.

Using unevaluatedProperties: false would correctly evaluate the properties
provided by the $ref, which would also allow the redundant local declaration
of backlight: true to be removed.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260809200107.842945-1-marek.vasut+renesas@mailbox.org?part=1