Re: [PATCH v6 2/5] arm64: dts: qcom: Add Kalambo SoC

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] The `bwmon_cluster0` bandwidth monitor PMU node is not deleted for the Kalambo SoC, despite its corresponding CPU cluster being removed.
--

--- Patch [2]: [PATCH v6 2/5] arm64: dts: qcom: Add Kalambo SoC ---
commit 5b1921ede3b67f6a0faacd0ff5d06c244a23debf
Author: Gopikrishna Garmidi <gopikrishna.garmidi@oss.qualcomm.com>

arm64: dts: qcom: Add Kalambo SoC

Introduces support for the Qualcomm Kalambo SoC, which is derived from
the Mahua SoC. This removes CPU cluster 0, reassigns the surviving
cluster 1 as cluster 0, and adjusts SCMI transport regions and PDC
input pins.

> diff --git a/arch/arm64/boot/dts/qcom/kalambo.dtsi b/arch/arm64/boot/dts/qcom/kalambo.dtsi
> new file mode 100644
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/kalambo.dtsi
> @@ -0,0 +1,119 @@
> +// SPDX-License-Identifier: BSD-3-Clause
> +/*
> + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
> + */
> +
> +#include "mahua.dtsi"
> +
> +/delete-node/ &cluster0_pd;
> +/delete-node/ &cpu_map;
> +/delete-node/ &cpu0;

[Severity: High]
Should the bwmon_cluster0 node be deleted here as well?

Since cluster 0 is removed for Kalambo, the bandwidth monitor node
(bwmon_cluster0) inherited from the base dtsi files will still be present
and active. Will the qcom,sdm845-bwmon driver trigger a Synchronous External
Abort during boot when it probes and attempts to access the memory-mapped PMU
registers for the now non-existent hardware cluster?

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260810-b4-kalambo-crd-v6-0-744e8ad1dae9@oss.qualcomm.com?part=2