Re: [PATCH 03/10] dt-bindings: phy: qcom,ipq806x-usb-phy-ss: add MSM8974 SS PHY

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The schema unconditionally applies IPQ806x hardware defaults to the newly introduced MSM8974 variant, contradicting the commit message claim that the parameters differ.
--

--- Patch [3]: [PATCH 03/10] dt-bindings: phy: qcom,ipq806x-usb-phy-ss: add MSM8974 SS PHY ---
commit c3a8fb6b674551444c17885768e8da57eb5bdf84
Author: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>

dt-bindings: phy: qcom,ipq806x-usb-phy-ss: add MSM8974 SS PHY

This commit adds the msm8974 compatible string to the ipq806x dwc3
superspeed phy device tree binding. It notes that while the hardware layout
is identical, the parameters differ from those specified for ipq806x.

> diff --git a/Documentation/devicetree/bindings/phy/qcom,ipq806x-usb-phy-ss.yaml b/Documentation/devicetree/bindings/phy/qcom,ipq806x-usb-phy-ss.yaml
> index 6cf5c6c06072c..29cb43cf73481 100644
> --- a/Documentation/devicetree/bindings/phy/qcom,ipq806x-usb-phy-ss.yaml
> +++ b/Documentation/devicetree/bindings/phy/qcom,ipq806x-usb-phy-ss.yaml
> @@ -16,7 +16,9 @@ description:
>  
>  properties:
>    compatible:
> -    const: qcom,ipq806x-usb-phy-ss
> +    oneOf:
> +      - const: qcom,ipq806x-usb-phy-ss
> +      - const: qcom,msm8974-usb-phy-ss

[Severity: Low]
The commit message states that the hardware-specific parameters differ from
those specified for ipq806x. However, will dt-schema validation now
incorrectly interpret omitted optional properties on msm8974 nodes as having
the ipq806x defaults?

For example, the schema currently defines global defaults:

  qcom,rx-eq:
    $ref: /schemas/types.yaml#/definitions/uint32
    description: Override value for rx_eq.
    default: 4

Should there be a conditional block to ensure these defaults are scoped
strictly to the qcom,ipq806x-usb-phy-ss compatible, or should the differing
msm8974 defaults be explicitly specified?

>  
>    "#phy-cells":
>      const: 0

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260810-msm8974-usb3-v1-0-1a47e1185524@oss.qualcomm.com?part=3