Re: [PATCH 3/3] ARM: dts: vf: add Iris carrier board support for Colibri VF50 and VF61

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Missing Device Tree binding documentation for new compatible strings.
--

--- Patch [3]: [PATCH 3/3] ARM: dts: vf: add Iris carrier board support for Colibri VF50 and VF61 ---
commit 5035e51faad7bb81da2db6e831c70fb93999bdf7
Author: Mehmet Fide <mehmet.fide@screeningeagle.com>

ARM: dts: vf: add Iris carrier board support for Colibri VF50 and VF61

This commit adds device tree files for the Iris carrier board when used with
the Colibri VF50 and VF61 modules. It introduces a common device tree include
along with specific device trees for each module variant to enable hardware
interfaces.

> diff --git a/arch/arm/boot/dts/nxp/vf/vf500-colibri-iris.dts b/arch/arm/boot/dts/nxp/vf/vf500-colibri-iris.dts
> new file mode 100644
> index 0000000000000..53dd252f3b769
> --- /dev/null
> +++ b/arch/arm/boot/dts/nxp/vf/vf500-colibri-iris.dts

[ ... ]

> +/ {
> +	model = "Toradex Colibri VF50 on Iris Carrier Board";
> +	compatible = "toradex,vf500-colibri_vf50-on-iris", "toradex,vf500-colibri_vf50", "fsl,vf500";

[Severity: Low]
Should this new compatible string be documented in the corresponding device
tree binding file? Without an update to the bindings, such as in
Documentation/devicetree/bindings/arm/fsl.yaml, running make dtbs_check
will likely result in validation warnings for
toradex,vf500-colibri_vf50-on-iris.

> +};

[ ... ]

> diff --git a/arch/arm/boot/dts/nxp/vf/vf610-colibri-iris.dts b/arch/arm/boot/dts/nxp/vf/vf610-colibri-iris.dts
> new file mode 100644
> index 0000000000000..2882c8783c280
> --- /dev/null
> +++ b/arch/arm/boot/dts/nxp/vf/vf610-colibri-iris.dts

[ ... ]

> +/ {
> +	model = "Toradex Colibri VF61 on Iris Carrier Board";
> +	compatible = "toradex,vf610-colibri_vf61-on-iris", "toradex,vf610-colibri_vf61", "fsl,vf610";

[Severity: Low]
Similarly, does toradex,vf610-colibri_vf61-on-iris need to be added to the
bindings documentation to prevent schema validation warnings during build
tests?

> +};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260810140053.2793495-1-mehmet.fide@gmail.com?part=3