Re: [PATCH v5 08/14] perf: Add gtrace AUX buffer trace format type

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The commit modifies the kernel UAPI header `include/uapi/linux/perf_event.h` but fails to mirror these changes to `tools/include/uapi/linux/perf_event.h`.
--

--- Patch [8]: [PATCH v5 08/14] perf: Add gtrace AUX buffer trace format type ---
commit 6637722bfb1d15a6e1471e7ca1494775099312c6
Author: Mayuresh Chitale <mayuresh.chitale@oss.qualcomm.com>

perf: Add gtrace AUX buffer trace format type

This commit adds definitions for the gtrace PMU AUX buffer formats to the 
perf event UAPI header. It specifically defines the RISC-V E-trace format flag 
so the perf tool can decode the recorded payload.

> diff --git a/include/uapi/linux/perf_event.h b/include/uapi/linux/perf_event.h
> index fd10aa8d697f2..ca2d8614a7804 100644
> --- a/include/uapi/linux/perf_event.h
> +++ b/include/uapi/linux/perf_event.h
> @@ -1311,6 +1311,10 @@ enum perf_callchain_context {
>  #define PERF_AUX_FLAG_CORESIGHT_FORMAT_CORESIGHT 0x0000 /* Default for backward compatibility */
>  #define PERF_AUX_FLAG_CORESIGHT_FORMAT_RAW	 0x0100 /* Raw format of the source */
>  
> +/* gtrace PMU AUX buffer formats */
> +#define PERF_AUX_FLAG_GTRACE_FORMAT_UNKNOWN	 0x0000
> +#define PERF_AUX_FLAG_GTRACE_FORMAT_ETRACE	 0x0100 /* RISC-V E-trace format */
> +

[Severity: Low]
Does this change also need to be mirrored in
tools/include/uapi/linux/perf_event.h?

When building the perf tool, missing the synchronization of UAPI headers
typically triggers a warning that the kernel ABI header differs from the latest
version. Updating the tools directory copy would also ensure the new
PERF_AUX_FLAG_GTRACE_FORMAT_ETRACE macro is accessible to the perf userspace
code within the same tree.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260810152223.3946743-1-mayuresh.chitale@oss.qualcomm.com?part=8