Re: [PATCH v3 7/7] ARM: dts: nxp: imx6qdl-wandboard: Replace clock-frequency in camera sensor node

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The patch introduces a blank line in the device tree node, directly contradicting the "Changes since v1" section of the commit message which states "- Drop added blank line".
--

--- Patch [7]: [PATCH v3 7/7] ARM: dts: nxp: imx6qdl-wandboard: Replace clock-frequency in camera sensor node ---
commit c2dd0680ebe87860961c5447228271fe2e5bfa7b
Author: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

ARM: dts: nxp: imx6qdl-wandboard: Replace clock-frequency in camera sensor node

This commit replaces the deprecated clock-frequency property with
assigned-clocks and assigned-clock-rates for the camera sensor node
in the device tree.

> diff --git a/arch/arm/boot/dts/nxp/imx/imx6qdl-wandboard.dtsi b/arch/arm/boot/dts/nxp/imx/imx6qdl-wandboard.dtsi
> index 26489eccd5fbe..f3aaca039953b 100644
> --- a/arch/arm/boot/dts/nxp/imx/imx6qdl-wandboard.dtsi
> +++ b/arch/arm/boot/dts/nxp/imx/imx6qdl-wandboard.dtsi
> @@ -137,7 +137,9 @@ camera@3c {
>  		pinctrl-0 = <&pinctrl_ov5645>;
>  		reg = <0x3c>;
>  		clocks = <&clks IMX6QDL_CLK_CKO2>;
> -		clock-frequency = <24000000>;
> +		assigned-clocks = <&clks IMX6QDL_CLK_CKO2>;
> +		assigned-clock-rates = <24000000>;
> +

[Severity: Low]
This isn't a bug, but the "Changes since v1" section of the commit message
states "- Drop added blank line". It looks like the blank line was still
accidentally included here in the camera@3c node. Should this line be removed
to match the changelog?

>  		vdddo-supply = <&reg_1p8v>;
>  		vdda-supply = <&reg_2p8v>;
>  		vddd-supply = <&reg_1p5v>;

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260810180604.3034255-1-laurent.pinchart@ideasonboard.com?part=7