From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D158E3DD521 for ; Tue, 11 Aug 2026 19:37:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786477029; cv=none; b=VbJHXyepjOgbddmZ6OAvMnZwVrf/Neh15WIdJSC/lhAATYqAf6Kyp1VTmh1VKXyxJzn5WZ3Y0Hm6Lmy4Q7fn8Fj0Y5wDtApRkZj6pJVJZncs9ai8C5lgaEGtA/E6Avm0uPbXqVenCV/GtJBa73z4RTFWVZuErQbigELjkMWnZFw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786477029; c=relaxed/simple; bh=I+AMBIPL88pj6SwRQqKUIsROOLJCx61KzFuc9dOZb8c=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type; b=kxtXqW+IDfxpcmPKjUPI8SVJJ1ZwCIfa69smieRwBgUuebOzn6n4cYzg3wGa35IwVpLjirIl0Uqjp7qt1B9w6aS5Q1pilAoL/ksJKy3ZCt+IkyKRj1PZIH6WOyQVb5hgT1SrnmcBVCdiS6gf6xypvmVBkR6MGVLc+VdudzM7UVY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=e1Kmx3sb; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="e1Kmx3sb" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-4954f5e8020so752385e9.2 for ; Tue, 11 Aug 2026 12:37:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786477026; x=1787081826; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:message-id:date :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to :content-type; bh=0JsV02jiIk99Htrjv4Tooh1nCMqCT9M9OeWRZPiqd+Y=; b=e1Kmx3sb6z/M7WKzX+TGntbI5YIGhInWzifVfNfJVj8YXmklMblikrH2YawOph4rcA xTylHlUmxlvwK4RuNhsCXFGY3SRGguGQXmnEmUBCjZY3iTiY5Z1J7v+5BgWZz4/uSNQA i+RncX6q7n5p+k27nts5pfd8glZp9PlGEJYPUzLu9ziMdr9K1l7LVwkm38kAb/aoYUwb VVqJktfE+aPL09moK0lOXHqXZ9abC8XiIFGW0xHKg7k8MLgtGLw27Ou7vFxCcRKSvVAo jZbJxGITg66GdQ3lH8vWAltYLwA/szkVsFld5O0/jw7oEkpVoEiZCfQk3dKWxdTQMxiO vemA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786477026; x=1787081826; h=content-transfer-encoding:content-type:mime-version:message-id:date :subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=0JsV02jiIk99Htrjv4Tooh1nCMqCT9M9OeWRZPiqd+Y=; b=ev3ne9/UCAZFOERUNlRdGPXsetWSslD6aiYXgK/hnJRg8I2Ej4tiikNtyKcXCMh7r9 W2BxN0947T7fMlHK9XghcD+P+oF/xvJ90u8mtFIWgNgc8fjF3NZYQVtYhG+X5mjDUjgq A97uHqpDFYSKoZBm9wUD/WC6wPBWblo9EgkHl3g8zpg7meTh8I/0hpIUKJ8Rxeq3M5Si JFkQHiiqpYbpK1JJH3E7vpi+ktx5iy85nFWpW1tkEgdawWAB/7JNFmdf1NoGapHC/AXv O54+ecXOQMMp+efH3v3Sv6cqWdKFff3z7Xco2VvxtBYDVgsFaafpImRIf2RwV+iQ5KdC LyzQ== X-Forwarded-Encrypted: i=1; AHgh+Ro26gQb5R/FpP3Rqh8xj8jCu3PiBGm4prr0J3JCC+/kEtI2l6QOlP4veqcq1a/dxeMHrEgoVeYJ35R4@vger.kernel.org X-Gm-Message-State: AOJu0YwCD5oSv+y4TCR8ZtJuy0vAutMKmHkOtHXCdAWorzPFfEbzSy/1 sKTh0eeday+Ytpod4IF3YxRQIpa8UCm4KyunZ1jDaPHMXG+07ucjythD X-Gm-Gg: AR+sD1146r+pyKBCVRFGipdbko5guCf0azkUimDmBF4H/HqAtxE+CFBU7ABi/ixdN2m F4zl1b9esszO7XgyuelM4O2KVS+QLIBpkGfw1zCvvZYpgxz1xDqTAAQGUoQ9D5zfzVAsVUTBKgC V5cZRXIg40ZSKQ2H4poeZvOdENC2PTxVIWDE/WWzshEgImnB8Zjilj6pZoOuKFBa+Up3z0qOUBM Wy9C7I5b74G5rEa4+99UAX+uYWINxfhYmbd2TrGTkLjh+U35B9EW7fYodYWAFBsbNcjP7db8Jl7 KZdBycoLGhPFcdFqC8J91ud7XsNm36F30SA2PnZR8sOdzHs6TlssO7AQXsTyaBllY7b0s5ImHoY XM0Dn+n/8HXtqGF73gzhAEYHwje5nnIHTzZWubRZL6VI2D0a6A/QHgqC8LDDmq3BXa5RBId7BbH xyNiK6WakSwTiIgehl8tuWuPIpVankBnv33R8te/0EqMDkUh9rWShu8DeqxYX/M3wVsD4ad3VWf zPbldAHbC3mMUhl2+2u6yjWfd28wKPOaSk23aZy X-Received: by 2002:a05:600c:3589:b0:499:5e9e:1f50 with SMTP id 5b1f17b1804b1-4997842aa62mr87661505e9.4.1786477025980; Tue, 11 Aug 2026 12:37:05 -0700 (PDT) Received: from localhost.localdomain.pl ([89.151.31.85]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4997b15b807sm10130285e9.7.2026.08.11.12.37.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Aug 2026 12:37:05 -0700 (PDT) From: =?UTF-8?q?Rafa=C5=82=20Mi=C5=82ecki?= To: Andrew Lunn , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: Florian Fainelli , Jonas Gorski , Vladimir Oltean , netdev@vger.kernel.org, Hauke Mehrtens , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, =?UTF-8?q?Rafa=C5=82=20Mi=C5=82ecki?= , Semih Baskan Subject: [PATCH V2 net 1/2] b53: deal with Northstar devices using CPU port 5 or 7 Date: Tue, 11 Aug 2026 21:36:57 +0200 Message-ID: <20260811193658.14304-1-zajec5@gmail.com> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Rafał Miłecki Northstar devices have 3 CPU ports. Ports 5 and 7 may be used but have their limitations. Warn user when CPU port 8 isn't used and add EAP setup workaround to avoid non-functional standalone ports. Fixes: 4227ea91e265 ("net: dsa: b53: prevent standalone from trying to forward to other ports") Cc: Semih Baskan Signed-off-by: Rafał Miłecki Tested-by: Semih Baskan --- V2: Print warning on switch setup instead of on actual EAP mode change I added PATCH 2/2 as requested but I'm not sure what DT maintainers will say about it. I'd suggest to take this fix if there are not more objections on net changes so regression can be fixed. I believe we can take more time to improve Linux dealing with switch to be more optimal. drivers/net/dsa/b53/b53_common.c | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/drivers/net/dsa/b53/b53_common.c b/drivers/net/dsa/b53/b53_common.c index 3f5b9592794d..a9bc90b2ffd2 100644 --- a/drivers/net/dsa/b53/b53_common.c +++ b/drivers/net/dsa/b53/b53_common.c @@ -332,6 +332,14 @@ static void b53_set_eap_mode(struct b53_device *dev, int port, int mode) { u64 eap_conf; + /* + * Setting EAP_MODE_SIMPLIFIED with port 5/7 used as CPU port breaks + * standalone ports, see: + * https://lore.kernel.org/netdev/ce4d9b7b-aaf6-4796-94fb-8c3d6a1dcd4d@gmail.com/ + */ + if (is5301x(dev) && !dsa_is_cpu_port(dev->ds, B53_CPU_PORT)) + return; + if (is5325(dev) || is5365(dev) || dev->chip_id == BCM5389_DEVICE_ID) return; @@ -1281,6 +1289,18 @@ static int b53_setup(struct dsa_switch *ds) u16 pvid; int ret; + /* + * Northstar SoCs devices have 3 Ethernet controllers and 3 CPU ports: + * 5 (IMP1), 7, 8 (IMP0). This design was meant for dual IMP setups when + * WAN traffic goes to port 5 and LAN traffic goes to port 8. + * + * While all 3 ports support Broadcom header, ports 5 and 7 have their + * limitations. Features that relay on trapping to CPU (e.g. EAP, STP) + * won't work when using those as CPU ones. + */ + if (is5301x(dev) && !dsa_is_cpu_port(dev->ds, B53_CPU_PORT)) + dev_warn(dev->dev, "switch to CPU port 8 to use all switch features\n"); + /* Request bridge PVID untagged when DSA_TAG_PROTO_NONE is set * which forces the CPU port to be tagged in all VLANs. */ -- 2.51.0