From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F2244476CDE for ; Tue, 11 Aug 2026 19:42:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786477344; cv=none; b=roldWczpz3Q6/ZU/HwQS/6fkCq8OtIxYFXD3VGIpxe0B9aTFawcsYFO5XAWPJTpQ6xQsfftjnLx585z71x7ubqXh0t1NOoNA+pPd488ZrXvMJLEq4wrfYeVr4VJ2kh2rQPVCfYbloV/lja5w1Cj0ymj+X5JolVW9+m6t+dP0M6I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786477344; c=relaxed/simple; bh=iymtdZbAVDC4szK+VL2vsDv4Um3gp/9GnkovC0TOf7E=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=TgBzQyPRgXS/Cl0g0jQ1RdpQAVZQpliEVtq31K3PU3PIL2xb4o05RBz/heJHzQqSY3y6cefRYTO+k7BJ8/Dz6yGi0BbVqfu1m8aqtLbddwIxWx6Y5/2h4XaoVGFq0onssORWrgMkCjuikzS7ZoJnflRmFXNj6Yf/tHGfZLNKqkE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=rsu/2LTZ; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="rsu/2LTZ" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-4980dc26022so1738945e9.1 for ; Tue, 11 Aug 2026 12:42:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786477340; x=1787082140; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=+Lv+zt/h7dKa8TuGsaFOLj9Yjn5OU7W3HW8p5oLwNPc=; b=rsu/2LTZTEAhX//Q29JAAyuL/d9olDI3dISJO7M2kpO4uonZSqspmWPeTa8oQMf2P8 nn76FbxH6ph5p6mQYExRgWNQ6yeli/B1K7JQYo9aE3yQXqmzwugptTkPAJz3F+Q6h/j9 RuKKaMJV/pcndzbcx4HITrzLLcRIwWaftWJhsoioWPC/7CX4qkgQxhg6kimZ0jHf+LpW 13CIjZkuVbpfoPEdzgumoLs9XHDnHRh/iSR4BHFICtiNS/1ixJc0I/Iqn/2FRpU/Htc0 1NlSDDFf36CdkEiCHSermn/6v4njmioq1zdnQH4cnX0QR3TYPdqQhX3VjGY7aicIfsU9 g8Aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786477340; x=1787082140; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=+Lv+zt/h7dKa8TuGsaFOLj9Yjn5OU7W3HW8p5oLwNPc=; b=jcI6xKRMh81EIJ5g//D1+L6xhV6wVpxUW/CVxgu3xquqR39EfQ3/AWaPEBfX0/zF7K 3Tpy2biEdngYTsflP6JllT2YBD+eFoBFtnC6f89dYva71puJCdYrf0W1bqh4k5nOzHdc 7jaTd6y+0REKCoLTv1u9S4WEEAy8ZYOxzdSgUWMv4c1POj3Tewsq/Skw/2cwaSOxrdcj eShOdM+/h6C/PtDquClVlvS9nezLtasvRdzd6iuVC2okjf2g3N8g3H4X1ct9cTM3Y0ki 3uKEgGI/F+oQuEUp+iQwRuvaXL2ZHR6O36uz/o1/yz7L1bh0oPGr43CsfR/hDBV3q1Hc CPEA== X-Forwarded-Encrypted: i=1; AHgh+RpLdSjT+GFO87ID2cecnzQaKnfeOqrT+MERThQ4PHvCQiOC6TjU5WDNnUXuFHN3JvpvSQi0Xeo2Cv72@vger.kernel.org X-Gm-Message-State: AOJu0YwRbJxDKua301Eur8NcNcH6UC/eYdrIvt1xaSCIR4Q4jwnUZQCx DFbkWEnWQaYBtlt/0n6sem0O3OuB3Qh6PVMOZEp0V4Nht2sIsbymHjpSW1+R7g== X-Gm-Gg: AR+sD118H9Pb7JKsPOCtFeFwHftNwkw9BrGNr8KkuyaWScnCzYgIHO/+pwnemb6IUBg DpSHPjVsF+YOwpwoispm2cVArrxHwvHDMTpQTp5NT+WtoMKQAsFyTlDCgjoX/pSldfLwUfweraI sjJClkx5j3ekS0Gjio/dI0mykorHVB6MSbIC7TW7/XE6+clwsbJ+b2H0VXLZ1zu5zO3SgF0eA0N IGSWsm4xG327wz8IHlfpA5EPPXBceF5nF29zCIcb5bVWU9yBs8j62/wODvUyDoUdVmrIF442wZk +K2PU3g3JcQjIOus5LDk3D864/IA7mkfB3v9AobQ081DL62GsWCSe5GbnripAG0UcAemjOYZP4N 3SXeH/Jbx+RdXdn5o0FBxZnjWZNh1fIWvWoTireIgE4xN/s54IuLpnlZgMDU1MVZgQqgrKqRegR x6s2I9ZsenersJZO9hH24LuxWD0j/58mPQwfiyJ80C5i1JFrJqbxKJ/ruphskynA3F X-Received: by 2002:a05:600c:b85:b0:499:516b:83d5 with SMTP id 5b1f17b1804b1-4997845f3f3mr82515435e9.11.1786477339927; Tue, 11 Aug 2026 12:42:19 -0700 (PDT) Received: from antoniarch ([78.213.143.159]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4997b22784fsm2606535e9.2.2026.08.11.12.42.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Aug 2026 12:42:19 -0700 (PDT) From: Antoni Pokusinski To: alexandre.belloni@bootlin.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org Cc: linux-rtc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Antoni Pokusinski Subject: [PATCH v5 2/9] rtc: abx80x: fix error check after i2c_smbus_read in read_alarm() Date: Tue, 11 Aug 2026 21:40:27 +0200 Message-ID: <20260811194034.28937-3-apokusinski01@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260811194034.28937-1-apokusinski01@gmail.com> References: <20260811194034.28937-1-apokusinski01@gmail.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit i2c_smbus_read_i2c_block_data() returns the number of bytes read on success and a negative error code on failure. The existing code treated any non-zero return value as an error. Fix the error handling by checking only for negative return values. Fixes: 718a820a303c ("rtc: abx80x: add alarm support") Signed-off-by: Antoni Pokusinski --- drivers/rtc/rtc-abx80x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-abx80x.c b/drivers/rtc/rtc-abx80x.c index 5486d9d0b1e5..fdf9664ebb6f 100644 --- a/drivers/rtc/rtc-abx80x.c +++ b/drivers/rtc/rtc-abx80x.c @@ -294,7 +294,7 @@ static int abx80x_read_alarm(struct device *dev, struct rtc_wkalrm *t) err = i2c_smbus_read_i2c_block_data(client, ABX8XX_REG_ASC, sizeof(buf), buf); - if (err) + if (err < 0) return err; irq_mask = i2c_smbus_read_byte_data(client, ABX8XX_REG_IRQ); -- 2.55.0