Re: [PATCH v3 3/9] dt-bindings: arm: apple: apple,pmgr: Add t8132 compatible

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Missing companion binding update for child PMGR power states (`apple,t8132-pmgr-pwrstate`) in `apple,pmgr-pwrstate.yaml`.
--

--- Patch [3]: [PATCH v3 3/9] dt-bindings: arm: apple: apple,pmgr: Add t8132 compatible ---
commit 2d86c5231638bf787326c9263ce70838cbe09c42
Author: Yureka Lilian <yureka@cyberchaos.dev>

dt-bindings: arm: apple: apple,pmgr: Add t8132 compatible

The PMGR blocks on Apple silicon M4 SoCs (t8132) are compatible with the
M1/M2/M3 predecessors. Add "apple,t8132-pmgr" as M4 specific compatible.

> diff --git a/Documentation/devicetree/bindings/arm/apple/apple,pmgr.yaml b/Documentation/devicetree/bindings/arm/apple/apple,pmgr.yaml
> index 1d2001836eb48..da660fa13f771 100644
> --- a/Documentation/devicetree/bindings/arm/apple/apple,pmgr.yaml
> +++ b/Documentation/devicetree/bindings/arm/apple/apple,pmgr.yaml
> @@ -41,6 +41,7 @@ properties:
>                - apple,t6030-pmgr
>                - apple,t6031-pmgr
>                - apple,t8122-pmgr
> +              - apple,t8132-pmgr

[Severity: Medium]
Should the companion power state binding be updated to include the new
generation as well?

When adding apple,t8132-pmgr here, the child PMGR power states typically
require a corresponding update in
Documentation/devicetree/bindings/power/apple,pmgr-pwrstate.yaml to pass
schema validation. 

For example, the previous generation is listed there as:

properties:
  compatible:
    oneOf:
      ...
      - enum:
          - apple,t6020-pmgr-pwrstate
          - apple,t6030-pmgr-pwrstate
          - apple,t6031-pmgr-pwrstate
          - apple,t8122-pmgr-pwrstate

Will apple,t8132-pmgr-pwrstate be needed in that list for M4 device trees?

>            - const: apple,t8103-pmgr
>            - const: syscon
>            - const: simple-mfd

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260811-apple-m4-initial-devicetrees-v3-0-6bf32d45ad0b@cyberchaos.dev?part=3