From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-zbxj-a91.jellyfish.systems (out-zbxj-a91.jellyfish.systems [198.54.127.91]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A21D03FBB44 for ; Tue, 11 Aug 2026 22:02:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.54.127.91 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786485731; cv=none; b=QHppRQBG/ZMvB1XzFmmRX+ecFY6CuhPhDlE3XvPZX07m3gTPpeOr4IR6UxooA293OzrS2ilooWH2eobqbkiou72dHK2uEk8DFAPxskiytPOG634Mc/xPuSoBdrpgmcf2P9A0KZScqfqX/wGGGBDDnBL0I0Sey9tgOoVdjM+ukDo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786485731; c=relaxed/simple; bh=p+SS7vZxOAXOrGGtNcEayjNQLffbukPNwaC7Z8qdp9A=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=XdEhs7luSLIR58670ir6wYeA4UCksF5hq7bOSL0omakJxtlT1ZbL2yayzU53gyuRxsXbfOZg3OTji2AdWxNabp6SUe3cuOvZPm4kl4pRCJI8tyQgi5cy+rLm6XL+U+YhVvwYD72fqfLbGhfKmSJguCxazmR+iqmBEA6r22k56T0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=catcrafts.net; spf=pass smtp.mailfrom=catcrafts.net; arc=none smtp.client-ip=198.54.127.91 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=catcrafts.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=catcrafts.net Received: from mail.privateemail.com (unknown [87.215.145.39]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.privateemail.com (Postfix) with ESMTPSA id 4hKQZT269Pz8sWQ; Tue, 11 Aug 2026 22:01:53 +0000 (UTC) From: Jorijn van der Graaf To: David Heidelberg , Krzysztof Kozlowski , Krzysztof Kozlowski Cc: Krzysztof Kozlowski , Andrew Lunn , Bjorn Andersson , Conor Dooley , Conor Dooley , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Konrad Dybcio , Konrad Dybcio , Paolo Abeni , Rob Herring , Luca Weiss , devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, oe-linux-nfc@lists.linux.dev, Jorijn van der Graaf Subject: [PATCH v5 2/6] nfc: s3fwrn5: use the "s3fwrn5_i2c" string literal directly Date: Wed, 12 Aug 2026 00:01:31 +0200 Message-ID: <20260811220135.472380-3-jorijnvdgraaf@catcrafts.net> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260811220135.472380-1-jorijnvdgraaf@catcrafts.net> References: <20260811220135.472380-1-jorijnvdgraaf@catcrafts.net> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Envelope-From: jorijnvdgraaf@catcrafts.net The S3FWRN5_I2C_DRIVER_NAME define is an indirection for a string that is fixed ABI (the driver name) and only used within this file. Spell the string out at its three users and drop the define. Suggested-by: David Heidelberg Assisted-by: Claude:claude-fable-5 Signed-off-by: Jorijn van der Graaf --- drivers/nfc/s3fwrn5/i2c.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/nfc/s3fwrn5/i2c.c b/drivers/nfc/s3fwrn5/i2c.c index cb73993446e0..c528c085b43e 100644 --- a/drivers/nfc/s3fwrn5/i2c.c +++ b/drivers/nfc/s3fwrn5/i2c.c @@ -16,8 +16,6 @@ #include "phy_common.h" -#define S3FWRN5_I2C_DRIVER_NAME "s3fwrn5_i2c" - struct s3fwrn5_i2c_phy { struct phy_common common; struct i2c_client *i2c_dev; @@ -186,7 +184,7 @@ static int s3fwrn5_i2c_probe(struct i2c_client *client) ret = devm_request_threaded_irq(&client->dev, phy->i2c_dev->irq, NULL, s3fwrn5_i2c_irq_thread_fn, IRQF_ONESHOT, - S3FWRN5_I2C_DRIVER_NAME, phy); + "s3fwrn5_i2c", phy); if (ret) goto s3fwrn5_remove; @@ -205,7 +203,7 @@ static void s3fwrn5_i2c_remove(struct i2c_client *client) } static const struct i2c_device_id s3fwrn5_i2c_id_table[] = { - { .name = S3FWRN5_I2C_DRIVER_NAME }, + { .name = "s3fwrn5_i2c" }, { } }; MODULE_DEVICE_TABLE(i2c, s3fwrn5_i2c_id_table); @@ -218,7 +216,7 @@ MODULE_DEVICE_TABLE(of, of_s3fwrn5_i2c_match); static struct i2c_driver s3fwrn5_i2c_driver = { .driver = { - .name = S3FWRN5_I2C_DRIVER_NAME, + .name = "s3fwrn5_i2c", .of_match_table = of_s3fwrn5_i2c_match, }, .probe = s3fwrn5_i2c_probe, -- 2.55.0