From: Krzysztof Kozlowski <krzk@kernel.org>
To: Qiang Yu <qiang.yu@oss.qualcomm.com>
Cc: Bjorn Andersson <andersson@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Brian Masney <bmasney@redhat.com>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Taniya Das <taniya.das@oss.qualcomm.com>,
Konrad Dybcio <konradybcio@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/3] dt-bindings: clock: qcom: Move x1e80100 TCSR to own binding
Date: Wed, 12 Aug 2026 13:20:39 +0200 [thread overview]
Message-ID: <20260812-lively-determined-loon-31f65e@quoll> (raw)
In-Reply-To: <20260812-hamoa_tcsr_qref_0812-v3-1-dc7627169c6d@oss.qualcomm.com>
On Wed, Aug 12, 2026 at 12:27:31AM -0700, Qiang Yu wrote:
> + clocks:
> + items:
> + - description: TCXO pad clock
> +
> + reg:
> + maxItems: 1
> +
> + '#clock-cells':
> + const: 1
> +
> + '#reset-cells':
> + const: 1
> +
> + vdda-qrefrpt0-0p9-supply: true
> + vdda-qrefrpt1-0p9-supply: true
> + vdda-qrefrpt2-0p9-supply: true
> + vdda-qrefrpt3-0p9-supply: true
> + vdda-qrefrpt4-0p9-supply: true
> + vdda-qrefrx0-0p9-supply: true
> + vdda-qrefrx1-0p9-supply: true
> + vdda-qrefrx2-0p9-supply: true
> + vdda-qrefrx3-0p9-supply: true
> + vdda-qrefrx4-0p9-supply: true
> + vdda-qreftx0-0p9-supply: true
> + vdda-qreftx0-1p2-supply: true
> + vdda-qreftx1-0p9-supply: true
> + vdda-qreftx1-1p2-supply: true
> + vdda-refgen0-0p9-supply: true
> + vdda-refgen0-1p2-supply: true
> + vdda-refgen2-0p9-supply: true
> + vdda-refgen2-1p2-supply: true
> +
> +required:
> + - compatible
> + - clocks
> + - '#clock-cells'
> + - '#reset-cells'
This is unexplained ABI change. When you are asked, you need to address
feedback from LLM, not blindly implement it without checking its
validity.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-08-12 11:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-12 7:27 [PATCH v3 0/3] clk: qcom: Migrate x1e80100 TCSR to clk_ref helper Qiang Yu
2026-08-12 7:27 ` [PATCH v3 1/3] dt-bindings: clock: qcom: Move x1e80100 TCSR to own binding Qiang Yu
2026-08-12 7:35 ` sashiko-bot
2026-08-12 11:20 ` Krzysztof Kozlowski [this message]
2026-08-12 7:27 ` [PATCH v3 2/3] clk: qcom: tcsrcc-x1e80100: Migrate to clk_ref helper Qiang Yu
2026-08-12 10:24 ` Abel Vesa
2026-08-12 7:27 ` [PATCH v3 3/3] arm64: dts: qcom: hamoa/purwa: Add QREF regulator supplies Qiang Yu
2026-08-12 10:25 ` Abel Vesa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260812-lively-determined-loon-31f65e@quoll \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=bmasney@redhat.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=qiang.yu@oss.qualcomm.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=taniya.das@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox