From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E24E344C4F0 for ; Wed, 12 Aug 2026 13:28:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786541294; cv=none; b=mPP1S1twVNJwo31x/K9ogqogktuOsiTg/RPdVEiFE6WcD2S2w9SK7HJT2a5gHhGqLMD8cGZYZwzmxhw0g8Ritdtw3B3MeDZynwvlpvNdaIRGj24cHe/t6OsE50SVUVu66DI695Syunp3kq9Y+Zer2UTDjAWd3bR1TCYnYQoS2bc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786541294; c=relaxed/simple; bh=Jh5wY+u3V7MIGQ3+qn12frIPWOUTacrPWbaM8jJim1s=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type; b=EXlG8VOq422p6wthZI0ieVH0x8A542k8MjL9F65kR5zGC36U7AKT618i4pn5sNiCiNv5GbVDPosnKjuT/vw5yoHO8aTtBnAkOceXKH73x1Lg1ujwxZOBnxTP/GQjZ68LmAm8Iqs/TrQkxhKxkYfodl+iho3EXT9on44uZCh4Y18= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kc4CrHJU; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kc4CrHJU" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-495590dde14so11906025e9.0 for ; Wed, 12 Aug 2026 06:28:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786541289; x=1787146089; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:message-id:date :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to :content-type; bh=nV9YBKtsEulfVjfXfwXT5cEXH+7jiV0CfcyyBTJ0j6E=; b=kc4CrHJU5NNHrrCfQkswJHFmU0CdgqOvdro10qqQQZkqc+lmUvysLVOW+LJVH2Upa7 MnN4x5Svk77w1qlqB7fANp31Z1Z5zsEqOA3E6LS4MrmSUK+JoAM4lTgVSHcEwUBBcHvy CEeynzCARdOc+BoyeIuwfBaXeHAg8JPgTbLVONaKWNvba4wadVogvbnMuj55Aemx8G1p CkqwWNWxozD1HbngCoW+UOvNDVyLZ5Q3gxWbIgW7K9ZGS8L2eZ1Tn/huahgT0IjYIWj8 s/aSN2TzZKb/P9lDiY88yvUC4S8hq3ahAWBqywcbx/UNtH8Y6TdGm5C+bBsRl2HpPARN btLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786541289; x=1787146089; h=content-transfer-encoding:content-type:mime-version:message-id:date :subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=nV9YBKtsEulfVjfXfwXT5cEXH+7jiV0CfcyyBTJ0j6E=; b=aEzdU3GV7iVvUOshAC+98ZHRapc12KmCT0PWbIczKzdMxWNWxePDlIHkLS1ae950T9 7CCgg5WpuOA8bxrIBEd0UOIa/4E36o66HOgEWPuwAMEGO8+XIaPSVrxno/DKSVn/mrQy hHfQ+s12H01MEcok+2rKdH0Jf6w5PVGD5bGiSJ8PPSfE2rC4AvZCZymGqLlIlWV088FX XdfVcIZckoA1B6FXqR4Fl15SgCa9MrXX2tpA/sw2PyH6m//mBjxO2N0Gza8Vc1Mw5XA0 HdcFc/6bQ3WQtfT1TRbHzaQkB/uURN0DEvKJpkU7rHnAANNlCLwCNYUsrIynVlnZpsLd hE7A== X-Forwarded-Encrypted: i=1; AHgh+RoFZqJ81cAbBP354Woyf4X1P7X8Zs4lRaWj786PTr24TsI8na/k7kKVDbXGXOXKPjUsLp+ClMYaAFsg@vger.kernel.org X-Gm-Message-State: AOJu0YxDwcE/SkdcWH4SYwtpX3ycwN1q1MzcWrNEN6g93RvrIT4jzoPC pIEnfOneT3hVEUz2RFtzU/ZiRwCqBaWciDgONkvrGsRtRUDucDqzeF+M X-Gm-Gg: AR+sD12X5Ua5TUDd0HBhRB9Ggc4CvAAICCA0Jew4CB9FsR28qU88GvyPGDCavBwK1kw A4KOyQjIajQZIPU/+aOd4GwnDf0wrdXKIwxM2ZBH3RUNM3OaGfy8JT8ABwufUcYAEHLG1U3Rc3o TcT6czL80W3gSgRmuE97DkHq4I/+RQnnEJZtf6evzjtI0HLVWJM/gqudiBpKrBX2eMfIGrBSq2i DWIFNpWMYH76eIT7rhABJv8wSKotZegioPHKPlZCYc9bZnrUy3Wb041cKz/NPCcFiZq4VXPfeVh IgAp/Rgq0Nt5EMqNUbNeKqZLnNxkZHVHP7myvry7vLfu+dMPAb56Hv2z57PFu4qu99pfpsiRw+H EpeK+fdBDoBZqDKeMBAQlYqaGURRuFHIv6gTJ3CPuWryS11haSeaJRLWopBpaabvwPn5MW2b2+a zaWfm/TVSWmmlYYbe44OwfPY8Hjca6Uk5++OIB7IuT5oLNzdt4mBfamdQk0RofWgKql06yGFzV1 l4dPgwRAravLHRgB09TK2xpufYcG9E0WHWJ3coX X-Received: by 2002:a05:600d:8494:10b0:499:5282:f8d1 with SMTP id 5b1f17b1804b1-4997c13bf0cmr53031495e9.12.1786541288777; Wed, 12 Aug 2026 06:28:08 -0700 (PDT) Received: from localhost.localdomain.pl ([89.151.31.85]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4997abf917csm87818995e9.13.2026.08.12.06.28.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Aug 2026 06:28:07 -0700 (PDT) From: =?UTF-8?q?Rafa=C5=82=20Mi=C5=82ecki?= To: Andrew Lunn , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: Florian Fainelli , Jonas Gorski , Vladimir Oltean , netdev@vger.kernel.org, Hauke Mehrtens , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, =?UTF-8?q?Rafa=C5=82=20Mi=C5=82ecki?= , Semih Baskan Subject: [PATCH V3 1/4 net] net: dsa: b53: deal with Northstar devices using CPU port 5 or 7 Date: Wed, 12 Aug 2026 15:27:52 +0200 Message-ID: <20260812132755.32585-1-zajec5@gmail.com> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Rafał Miłecki Northstar devices have 3 CPU ports. Ports 5 and 7 may be used but have their limitations. Warn user when CPU port 8 isn't used and add EAP setup workaround to avoid non-functional standalone ports. Fixes: 4227ea91e265 ("net: dsa: b53: prevent standalone from trying to forward to other ports") Cc: Semih Baskan Signed-off-by: Rafał Miłecki Tested-by: Semih Baskan --- This fixes a regression so it's a net.git material V2: Print warning on switch setup instead of on actual EAP mode change V3: Proper subject prefix & shorter comments (long one comes with 2/2) drivers/net/dsa/b53/b53_common.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/drivers/net/dsa/b53/b53_common.c b/drivers/net/dsa/b53/b53_common.c index 3f5b9592794d..5fd8362d0430 100644 --- a/drivers/net/dsa/b53/b53_common.c +++ b/drivers/net/dsa/b53/b53_common.c @@ -332,6 +332,14 @@ static void b53_set_eap_mode(struct b53_device *dev, int port, int mode) { u64 eap_conf; + /* + * On Northstar setting EAP_MODE_SIMPLIFIED with CPU port 5/7 breaks + * standalone ports, see: + * https://lore.kernel.org/netdev/ce4d9b7b-aaf6-4796-94fb-8c3d6a1dcd4d@gmail.com/ + */ + if (is5301x(dev) && !dsa_is_cpu_port(dev->ds, B53_CPU_PORT)) + return; + if (is5325(dev) || is5365(dev) || dev->chip_id == BCM5389_DEVICE_ID) return; @@ -1281,6 +1289,10 @@ static int b53_setup(struct dsa_switch *ds) u16 pvid; int ret; + /* Discourage users from using port 5 or 7 due to limited features */ + if (is5301x(dev) && !dsa_is_cpu_port(dev->ds, B53_CPU_PORT)) + dev_warn(dev->dev, "switch to CPU port 8 to use all switch features\n"); + /* Request bridge PVID untagged when DSA_TAG_PROTO_NONE is set * which forces the CPU port to be tagged in all VLANs. */ -- 2.51.0