From: sashiko-bot@kernel.org
To: "Tan Siewert" <tan@siewert.io>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v3 1/2] dt-bindings: arm: aspeed: add ASRock X470D4U BMC
Date: Wed, 12 Aug 2026 20:33:58 +0000 [thread overview]
Message-ID: <20260812203359.260CB1F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260812-ts-x470d4u-v3-1-c8e266f1663b@siewert.io>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The commit unintentionally introduces a second, undocumented compatible string `asrock,x470d4u-data64-bmc`.
--
--- Patch [1]: [PATCH v3 1/2] dt-bindings: arm: aspeed: add ASRock X470D4U BMC ---
commit edbc123921dd78f14b8c4849e14a649077a33ee2
Author: Tan Siewert <tan@siewert.io>
dt-bindings: arm: aspeed: add ASRock X470D4U BMC
This commit documents the compatible string for the ASRock X470D4U BMC board.
> diff --git a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml
> index dd7996960de3e..277c0e03cf488 100644
> --- a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml
> +++ b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml
> @@ -40,6 +40,8 @@ properties:
> - asrock,e3c256d4i-bmc
> - asrock,romed8hm3-bmc
> - asrock,spc621d8hm3-bmc
> + - asrock,x470d4u-bmc
> + - asrock,x470d4u-data64-bmc
[Severity: Low]
Is this second compatible string an accidental inclusion? The commit message
explicitly mentions a singular board addition.
The data64 suffix appears to be an internal convention used elsewhere in this
file exclusively for Facebook hardware with 64MB datastores, such as
facebook,wedge400-data64-bmc. This allows an undocumented string to pass
schema validation even though no such ASRock variant appears to exist.
> - asrock,x570d4u-bmc
> - bytedance,g220a-bmc
> - facebook,cmm-bmc
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260812-ts-x470d4u-v3-0-c8e266f1663b@siewert.io?part=1
next prev parent reply other threads:[~2026-08-12 20:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-12 20:28 [PATCH v3 0/2] ARM: dts: aspeed: ASRock Rack X470D4U BMC support Tan Siewert
2026-08-12 20:28 ` [PATCH v3 1/2] dt-bindings: arm: aspeed: add ASRock X470D4U BMC Tan Siewert
2026-08-12 20:33 ` sashiko-bot [this message]
2026-08-12 20:28 ` [PATCH v3 2/2] ARM: dts: aspeed: add asrock x470d4u bmc Tan Siewert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260812203359.260CB1F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=tan@siewert.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox