Devicetree
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Jiafei Pan <Jiafei.Pan@nxp.com>
Cc: andersson@kernel.org, mathieu.poirier@linaro.org,
	 krzysztof.kozlowski@linaro.org, peng.fan@nxp.com,
	Frank.Li@nxp.com, s.hauer@pengutronix.de,  kernel@pengutronix.de,
	festevam@gmail.com, imx@lists.linux.dev,
	 linux-arm-kernel@lists.infradead.org,
	linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org,
	 linux-kernel@vger.kernel.org, Zhiqiang.Hou@nxp.com,
	mingkai.hu@nxp.com
Subject: Re: [PATCH v4 1/4] dt-bindings: remoteproc: add imx-rproc-psci
Date: Thu, 13 Aug 2026 09:49:44 +0200	[thread overview]
Message-ID: <20260813-imposing-blazing-gharial-fbb19c@quoll> (raw)
In-Reply-To: <20260812104633.22420-2-Jiafei.Pan@nxp.com>

On Wed, Aug 12, 2026 at 06:46:30PM +0800, Jiafei Pan wrote:
> Add compatible string "fsl,imx-rproc-psci" for i.MX Cortex-A Core's
> remoteproc support.
> 
> Signed-off-by: Jiafei Pan <Jiafei.Pan@nxp.com>
> 
> ---
> Changes in v4:
> - Updated description to describe the hardware instead of the binding
> - Changed compatible to SoC-specific "fsl,imx93-rproc-psci" with
>   generic fallback "fsl,imx-rproc-psci"
> - Fixed example node name from "remoteproc-ca55-1" to "remoteproc"

You need to start using b4 to send patches or send them correctly... Why
is this response to some other thread?

> 
> ---
>  .../remoteproc/fsl,imx-rproc-psci.yaml        | 54 +++++++++++++++++++
>  1 file changed, 54 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/remoteproc/fsl,imx-rproc-psci.yaml
> 
> diff --git a/Documentation/devicetree/bindings/remoteproc/fsl,imx-rproc-psci.yaml b/Documentation/devicetree/bindings/remoteproc/fsl,imx-rproc-psci.yaml
> new file mode 100644
> index 000000000000..7d0d0da383a2
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/remoteproc/fsl,imx-rproc-psci.yaml
> @@ -0,0 +1,54 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/remoteproc/fsl,imx-rproc-psci.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: NXP i.MX Cortex-A Core Remote Processor via PSCI
> +
> +maintainers:
> +  - Jiafei Pan <Jiafei.Pan@nxp.com>
> +
> +description:
> +  NXP i.MX SoCs integrate multiple Cortex-A cores. On certain i.MX
> +  platforms, one or more of these cores can be offloaded to run RTOS
> +  or bare-metal firmware as a remote processor, while the remaining
> +  cores run Linux. The cores are powered on and off via PSCI (Power
> +  State Coordination Interface) CPU_ON/CPU_OFF calls to the firmware.
> +
> +properties:
> +  compatible:
> +    items:
> +      - enum:
> +          - fsl,imx93-ca55-rproc
> +      - const: fsl,imx-rproc-psci

Hm? So you just ignored the feedback?

> +
> +  fsl,cpus-mask:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    description:
> +      Bitmask indicating which CPU cores are assigned to this remote
> +      processor instance. Each bit represents a CPU core, where bit N
> +      corresponds to CPU N. For example, 0x2 (0b10) assigns CPU core 1,
> +      while 0x6 (0b110) assigns CPU cores 1 and 2.

How did you implement feedback from Sashiko?

> +
> +  memory-region:
> +    maxItems: 1
> +    description:
> +      Phandle to a reserved memory region to be used for the remote
> +      processor's code and data.
> +
> +required:
> +  - compatible
> +  - fsl,cpus-mask
> +  - memory-region
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +        remoteproc {

Odd indentation.

> +            compatible = "fsl,imx93-ca55-rproc", "fsl,imx-rproc-psci";
> +            /* bitmask: 0b10, assign A55 Core 1 */
> +            fsl,cpus-mask = <0x2>;
> +            memory-region = <&rtos_ca55_reserved>;
> +        };
> -- 
> 2.43.0
> 

  reply	other threads:[~2026-08-13  7:49 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-11  2:39 [PATCH v3 0/4] remoteproc: add Cortex-A Core remoteproc support on i.MX platforms Jiafei Pan
2026-05-11  2:39 ` [PATCH v3 1/4] dt-bindings: remoteproc: add imx-rproc-psci Jiafei Pan
2026-05-11 22:41   ` sashiko-bot
2026-05-14 11:38   ` Krzysztof Kozlowski
2026-08-12  9:19     ` Jiafei Pan
2026-08-12 10:02       ` Krzysztof Kozlowski
2026-08-12 10:46   ` [PATCH v4 0/4] remoteproc: add Cortex-A Core remoteproc support on i.MX platforms Jiafei Pan
2026-08-12 10:46     ` [PATCH v4 1/4] dt-bindings: remoteproc: add imx-rproc-psci Jiafei Pan
2026-08-13  7:49       ` Krzysztof Kozlowski [this message]
2026-08-13  7:51         ` Krzysztof Kozlowski
2026-08-12 10:46     ` [PATCH v4 2/4] remoteproc: imx_rproc: add support for Cortex-A Core Jiafei Pan
2026-08-12 10:46     ` [PATCH v4 3/4] remoteproc: imx_rproc: add autoboot support for A-core Jiafei Pan
2026-08-12 10:46     ` [PATCH v4 4/4] arm64: dts: imx93: Cortex-A Core remoteproc device node Jiafei Pan
2026-05-11  2:39 ` [PATCH v3 2/4] remoteproc: imx_rproc: add support for Cortex-A Core Jiafei Pan
2026-05-11 23:10   ` sashiko-bot
2026-05-11  2:39 ` [PATCH v3 3/4] remoteproc: imx_rproc: add autoboot support for A-core Jiafei Pan
2026-05-12  0:00   ` sashiko-bot
2026-05-11  2:39 ` [PATCH v3 4/4] arm64: dts: imx93: Cortex-A Core remoteproc device node Jiafei Pan
2026-05-12  0:37   ` sashiko-bot
2026-05-11  7:00 ` [PATCH v3 0/4] remoteproc: add Cortex-A Core remoteproc support on i.MX platforms Peng Fan
2026-05-11 17:10   ` Mathieu Poirier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260813-imposing-blazing-gharial-fbb19c@quoll \
    --to=krzk@kernel.org \
    --cc=Frank.Li@nxp.com \
    --cc=Jiafei.Pan@nxp.com \
    --cc=Zhiqiang.Hou@nxp.com \
    --cc=andersson@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=imx@lists.linux.dev \
    --cc=kernel@pengutronix.de \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-remoteproc@vger.kernel.org \
    --cc=mathieu.poirier@linaro.org \
    --cc=mingkai.hu@nxp.com \
    --cc=peng.fan@nxp.com \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox