From: sashiko-bot@kernel.org
To: "Anshul Dalal" <anshuld@ti.com>
Cc: robh@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: ti: k3-am625-beagleplay: Add boot phase tags for pmic
Date: Thu, 13 Aug 2026 08:34:50 +0000 [thread overview]
Message-ID: <20260813083450.7AAF01F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260813-beagleplay_pmic_boot_phase_fix-v1-1-4518e7cba940@ti.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] Removing `bootph-all` from the parent PMIC node prevents U-Boot from probing the PMIC and its regulators during early boot.
--
--- Patch [1]: [PATCH] arm64: dts: ti: k3-am625-beagleplay: Add boot phase tags for pmic ---
commit 7e0324188396a118a77eb80307cd8f4be050d7cb
Author: Anshul Dalal <anshuld@ti.com>
arm64: dts: ti: k3-am625-beagleplay: Add boot phase tags for pmic
This commit moves the 'bootph-all' tag from the parent tps65219 PMIC node
to all of its regulator sub-nodes. The intent is to ensure the PMIC
regulators are available during the boot phase.
> diff --git a/arch/arm64/boot/dts/ti/k3-am625-beagleplay.dts b/arch/arm64/boot/dts/ti/k3-am625-beagleplay.dts
> --- a/arch/arm64/boot/dts/ti/k3-am625-beagleplay.dts
> +++ b/arch/arm64/boot/dts/ti/k3-am625-beagleplay.dts
> @@ -681,7 +681,6 @@ rtc: rtc@68 {
> };
>
> tps65219: pmic@30 {
> - bootph-all;
> compatible = "ti,tps65219";
> reg = <0x30>;
[Severity: High]
Will removing bootph-all from the parent PMIC node prevent U-Boot from
probing the PMIC and its regulators during early boot?
During U-Boot's early boot phases, the driver model only binds nodes with
properties like bootph-all. If this is removed from the parent tps65219
node, the parent PMIC might be skipped.
Because the parent wouldn't be bound, would the driver model fail to scan
or bind its child regulator sub-nodes, even though this patch adds
bootph-all to them? Additionally, the U-Boot SPL fdtgrep tool strips
essential properties (such as reg and compatible) from untagged parent
nodes, which could break the I2C bus device attachment entirely.
[ ... ]
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260813-beagleplay_pmic_boot_phase_fix-v1-1-4518e7cba940@ti.com?part=1
prev parent reply other threads:[~2026-08-13 8:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-13 8:28 [PATCH] arm64: dts: ti: k3-am625-beagleplay: Add boot phase tags for pmic Anshul Dalal
2026-08-13 8:34 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260813083450.7AAF01F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=anshuld@ti.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox