From: Rob Herring <robh@kernel.org>
To: Esben Haabendal <esben@geanix.com>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Nikita Travkin" <nikita@trvn.ru>,
"Maslov Dmitry" <maslovdmitry@seeed.cc>,
"Kuppuswamy Sathyanarayanan"
<sathyanarayanan.kuppuswamy@linux.intel.com>,
"Thomas Gleixner" <tglx@kernel.org>,
"Pan Chuang" <panchuang@vivo.com>,
"Yangtao Li" <frank.li@vivo.com>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
"Krzysztof Kozlowski" <krzysztof.kozlowski@oss.qualcomm.com>
Subject: Re: [PATCH v4 3/7] dt-bindings: iio: light: ltr501: Add ltr329 compatible
Date: Thu, 13 Aug 2026 14:20:52 -0500 [thread overview]
Message-ID: <20260813192052.GB1981719-robh@kernel.org> (raw)
In-Reply-To: <871pc3y0id.fsf@geanix.com>
On Wed, Aug 12, 2026 at 02:41:14PM +0200, Esben Haabendal wrote:
> "Rob Herring" <robh@kernel.org> writes:
>
> > On Mon, Aug 10, 2026 at 09:11:13AM +0200, Esben Haabendal wrote:
> >> LTR-329ALS-01 is an ambient light sensor similar to LTR-303ALS-01, but
> >> without interrupt support.
> >>
> >> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> >> Acked-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
> >> Signed-off-by: Esben Haabendal <esben@geanix.com>
> >> ---
> >> Documentation/devicetree/bindings/iio/light/liteon,ltr501.yaml | 1 +
> >> 1 file changed, 1 insertion(+)
> >
> > sashiko issue should be addressed.
>
> I will.
>
> I guess it is best to add the new conditional statement under allOf, but
> as we already have an allOf block at the top, I would have to add it
> under that, which would place this new conditional statement related to
> specific compatible strings before the list of those compatible strings.
>
> It should work fine, but it looks a bit odd to me.
>
> I could also add it directly as an if statement, but that would only
> work as long as it is the only top level if statement, so that looks
> like a bad idea.
>
> Should I just stick it to the existing allOf list?
You can move the allOf to the end.
Rob
next prev parent reply other threads:[~2026-08-13 19:20 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-10 7:11 [PATCH v4 0/7] iio: light: ltr501: Add ltr329 support Esben Haabendal
2026-08-10 7:11 ` [PATCH v4 1/7] dt-bindings: iio: light: ltr501: Sort compatible enum array Esben Haabendal
2026-08-10 7:11 ` [PATCH v4 2/7] dt-bindings: iio: light: ltr501: Add missing ltr303 compatible Esben Haabendal
2026-08-10 7:11 ` [PATCH v4 3/7] dt-bindings: iio: light: ltr501: Add ltr329 compatible Esben Haabendal
2026-08-10 7:19 ` sashiko-bot
2026-08-10 15:50 ` Rob Herring
2026-08-12 12:41 ` Esben Haabendal
2026-08-13 19:20 ` Rob Herring [this message]
2026-08-10 7:11 ` [PATCH v4 4/7] iio: light: ltr501: Power down chip if request irq fails Esben Haabendal
2026-08-10 7:23 ` sashiko-bot
2026-08-10 7:11 ` [PATCH v4 5/7] iio: light: ltr501: Fix duplicated error message Esben Haabendal
2026-08-10 7:11 ` [PATCH v4 6/7] iio: light: ltr501: Add ltr329 driver support Esben Haabendal
2026-08-10 7:24 ` sashiko-bot
2026-08-10 19:57 ` Andy Shevchenko
2026-08-12 12:51 ` Esben Haabendal
2026-08-10 7:11 ` [PATCH v4 7/7] iio: light: ltr501: Fix sorting order of device arrays Esben Haabendal
2026-08-10 19:59 ` [PATCH v4 0/7] iio: light: ltr501: Add ltr329 support Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260813192052.GB1981719-robh@kernel.org \
--to=robh@kernel.org \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=esben@geanix.com \
--cc=frank.li@vivo.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzysztof.kozlowski@oss.qualcomm.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maslovdmitry@seeed.cc \
--cc=nikita@trvn.ru \
--cc=nuno.sa@analog.com \
--cc=panchuang@vivo.com \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
--cc=tglx@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox