From: sashiko-bot@kernel.org
To: "Hardeep Sharma" <hardeep.sharma@oss.qualcomm.com>
Cc: linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
conor+dt@kernel.org, robh@kernel.org
Subject: Re: [PATCH v2 13/15] dt-bindings: firmware: qcom,scm: Document SCM on Kuno SoC
Date: Fri, 14 Aug 2026 07:44:35 +0000 [thread overview]
Message-ID: <20260814074436.3E0F01F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260814-kuno-soc-support-v2-13-3079794f0f73@oss.qualcomm.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Missing 'qcom,scm-kuno' in the interrupts conditional block of the qcom,scm schema.
--
--- Patch [13]: [PATCH v2 13/15] dt-bindings: firmware: qcom,scm: Document SCM on Kuno SoC ---
commit 3c4b97f23fe59957f3113cdee2e0d2333d4ba10b
Author: Hardeep Sharma <hardeep.sharma@oss.qualcomm.com>
dt-bindings: firmware: qcom,scm: Document SCM on Kuno SoC
Document the SCM firmware interface found on the Qualcomm Kuno SoC.
> diff --git a/Documentation/devicetree/bindings/firmware/qcom,scm.yaml b/Documentation/devicetree/bindings/firmware/qcom,scm.yaml
> index 037d4ad8f718d..ecee5aef65a7b 100644
> --- a/Documentation/devicetree/bindings/firmware/qcom,scm.yaml
> +++ b/Documentation/devicetree/bindings/firmware/qcom,scm.yaml
> @@ -37,6 +37,7 @@ properties:
> - qcom,scm-ipq9574
> - qcom,scm-ipq9650
> - qcom,scm-kaanapali
> + - qcom,scm-kuno
> - qcom,scm-maili
> - qcom,scm-mdm9607
> - qcom,scm-milos
[Severity: Low]
Does this compatible string also need to be added to the interrupts conditional
block further down in the file?
If Kuno hardware supports wait-queue interrupts like the parallel Kaanapali
and Maili generations do, omitting it from the allOf interrupts block will
cause a schema validation regression:
allOf:
# Interrupts
- if:
not:
properties:
compatible:
contains:
enum:
- qcom,scm-eliza
- qcom,scm-hawi
- qcom,scm-kaanapali
- qcom,scm-maili
...
then:
properties:
interrupts: false
Can qcom,scm-kuno be added to this enum list to ensure device trees using the
wait-queue interrupt pass dt_binding_check?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260814-kuno-soc-support-v2-0-3079794f0f73@oss.qualcomm.com?part=13
next prev parent reply other threads:[~2026-08-14 7:44 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-14 7:31 [PATCH v2 00/15] Add initial support for Qualcomm Kuno SoC Hardeep Sharma
2026-08-14 7:31 ` [PATCH v2 01/15] soc: qcom: geni-se: allow selection on 32-bit ARM Qualcomm SoCs Hardeep Sharma
2026-08-14 7:31 ` [PATCH v2 02/15] dt-bindings: power: rpmpd: Document Kuno RPMh power domains Hardeep Sharma
2026-08-14 7:31 ` [PATCH v2 03/15] pmdomain: qcom: rpmhpd: Add power domains for Kuno Hardeep Sharma
2026-08-14 7:31 ` [PATCH v2 04/15] dt-bindings: clock: qcom,rpmhcc: Add Kuno RPMh clock controller Hardeep Sharma
2026-08-14 7:31 ` [PATCH v2 05/15] clk: qcom: clk-rpmh: Add support for Kuno RPMh clocks Hardeep Sharma
2026-08-14 7:45 ` sashiko-bot
2026-08-14 7:31 ` [PATCH v2 06/15] dt-bindings: interconnect: Add Qualcomm Kuno NoC Hardeep Sharma
2026-08-14 7:31 ` [PATCH v2 07/15] interconnect: qcom: Add Kuno interconnect provider driver Hardeep Sharma
2026-08-14 7:31 ` [PATCH v2 08/15] dt-bindings: pinctrl: qcom: Add Kuno TLMM Hardeep Sharma
2026-08-14 7:31 ` [PATCH v2 09/15] pinctrl: qcom: Add Kuno pinctrl driver Hardeep Sharma
2026-08-14 7:31 ` [PATCH v2 10/15] dt-bindings: clock: qcom: Add Kuno Global Clock Controller Hardeep Sharma
2026-08-14 7:31 ` [PATCH v2 11/15] clk: qcom: Add Global Clock Controller driver for Kuno Hardeep Sharma
2026-08-14 7:52 ` sashiko-bot
2026-08-14 7:31 ` [PATCH v2 12/15] dt-bindings: interrupt-controller: qcom,pdc: Add Kuno compatible string Hardeep Sharma
2026-08-14 7:31 ` [PATCH v2 13/15] dt-bindings: firmware: qcom,scm: Document SCM on Kuno SoC Hardeep Sharma
2026-08-14 7:44 ` sashiko-bot [this message]
2026-08-14 7:31 ` [PATCH v2 14/15] dt-bindings: arm: qcom: Document Kuno IDP board Hardeep Sharma
2026-08-14 7:31 ` [PATCH v2 15/15] ARM: dts: qcom: Add initial device tree for Kuno SoC Hardeep Sharma
2026-08-14 7:53 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260814074436.3E0F01F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hardeep.sharma@oss.qualcomm.com \
--cc=linux-clk@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox