Re: [PATCH v2 1/2] ASoC: dt-bindings: cs35l45: Adds SYNC properties

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Unnecessary use of a child node (`sync`) merely to group configuration properties.
--

--- Patch [1]: [PATCH v2 1/2] ASoC: dt-bindings: cs35l45: Adds SYNC properties ---
commit d073a7883f1698278c7c1d6cde1ee5dc878931ca
Author: Ricardo Rivera-Matos <rriveram@opensource.cirrus.com>

ASoC: dt-bindings: cs35l45: Adds SYNC properties

This commit introduces support for the multidevice synchronization (SYNC)
bus by adding properties that allow for the configuration of the device's
transmitter IDs.

> diff --git a/Documentation/devicetree/bindings/sound/cirrus,cs35l45.yaml b/Documentation/devicetree/bindings/sound/cirrus,cs35l45.yaml
> index 70f6c62aedca8..f64ba8c872b95 100644
> --- a/Documentation/devicetree/bindings/sound/cirrus,cs35l45.yaml
> +++ b/Documentation/devicetree/bindings/sound/cirrus,cs35l45.yaml

[ ... ]

> @@ -53,6 +53,29 @@ properties:
>      maximum: 3
>      default: 2
>  
> +  sync:
> +    description:
> +      Multidevice synchronization (SYNC) bus configuration
> +    type: object
> +    additionalProperties: false

[Severity: Low]
Is it necessary to use a child node here just to group configuration
properties? In Device Tree design, child nodes usually represent distinct
hardware components, sub-devices, buses, or standardized structural elements
rather than serving as logical folders to group related configuration
properties. 

Could the cirrus,sync-lsw-txid and cirrus,sync-sw-txid properties be placed
directly in the main device node instead?

[ ... ]

> @@ -155,5 +178,9 @@ examples:
>               gpio-ctrl = <0x1>;
>               gpio-dir = <0x1>;
>            };
> +          sync {
> +             cirrus,sync-lsw-txid = <0x1>;
> +             cirrus,sync-sw-txid = <0x1>;
> +          };

[Severity: Low]
Similarly, does the example need to encapsulate these properties in a sync
node? If the node is flattened in the schema, this example would need to be
updated to match.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260814223456.611160-1-rriveram@opensource.cirrus.com?part=1