From: sashiko-bot@kernel.org
To: "Kim Seer Paller" <kimseer.paller@analog.com>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v3 1/4] iio: ABI: Add DAC current powerdown attributes and 15kohm_to_gnd mode
Date: Mon, 17 Aug 2026 06:43:42 +0000 [thread overview]
Message-ID: <20260817064343.5EE8B1F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260817-iio-ad5710r-upstream-v3-1-3a4bf7b9c78b@analog.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The commit documents `out_current[Y]_powerdown_mode` and `out_current[Y]_powerdown` but fails to document the corresponding `out_current[Y]_powerdown_mode_available` attributes.
--
--- Patch [1]: [PATCH v3 1/4] iio: ABI: Add DAC current powerdown attributes and 15kohm_to_gnd mode ---
commit 3e8e143ec75a90ed9c1acf741435fcedffa2116c
Author: Kim Seer Paller <kimseer.paller@analog.com>
iio: ABI: Add DAC current powerdown attributes and 15kohm_to_gnd mode
This commit documents the out_currentY_powerdown and
out_currentY_powerdown_mode attributes for current-output DAC channels,
and adds the 15kohm_to_gnd powerdown mode.
> diff --git a/Documentation/ABI/testing/sysfs-bus-iio b/Documentation/ABI/testing/sysfs-bus-iio
> index a4f5595722ade..a0f9aada5c62d 100644
> --- a/Documentation/ABI/testing/sysfs-bus-iio
> +++ b/Documentation/ABI/testing/sysfs-bus-iio
> @@ -762,6 +762,8 @@ What: /sys/bus/iio/devices/iio:deviceX/out_voltageY_powerdown_mode
> What: /sys/bus/iio/devices/iio:deviceX/out_voltage_powerdown_mode
> What: /sys/bus/iio/devices/iio:deviceX/out_altvoltageY_powerdown_mode
> What: /sys/bus/iio/devices/iio:deviceX/out_altvoltage_powerdown_mode
> +What: /sys/bus/iio/devices/iio:deviceX/out_currentY_powerdown_mode
> +What: /sys/bus/iio/devices/iio:deviceX/out_current_powerdown_mode
[Severity: Low]
Since this commit documents out_current[Y]_powerdown_mode, should the
corresponding out_current[Y]_powerdown_mode_available attributes also be
documented?
The existing file has the available powerdown modes documented for voltage
outputs nearby:
What: /sys/.../iio:deviceX/out_voltageY_powerdown_mode_available
What: /sys/.../iio:deviceX/out_voltage_powerdown_mode_available
What: /sys/.../iio:deviceX/out_altvoltageY_powerdown_mode_available
What: /sys/.../iio:deviceX/out_altvoltage_powerdown_mode_available
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260817-iio-ad5710r-upstream-v3-0-3a4bf7b9c78b@analog.com?part=1
next prev parent reply other threads:[~2026-08-17 6:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-17 6:37 [PATCH v3 0/4] Add support for AD5710R/AD5711R DAC Kim Seer Paller
2026-08-17 6:37 ` [PATCH v3 1/4] iio: ABI: Add DAC current powerdown attributes and 15kohm_to_gnd mode Kim Seer Paller
2026-08-17 6:43 ` sashiko-bot [this message]
2026-08-17 6:37 ` [PATCH v3 2/4] dt-bindings: iio: dac: add adi,ad5710r.yaml Kim Seer Paller
2026-08-17 6:45 ` sashiko-bot
2026-08-17 6:37 ` [PATCH v3 3/4] iio: dac: ad3530r: parameterize DAC resolution Kim Seer Paller
2026-08-17 6:37 ` [PATCH v3 4/4] iio: dac: ad3530r: add support for AD5710R/AD5711R Kim Seer Paller
2026-08-17 6:52 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260817064343.5EE8B1F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kimseer.paller@analog.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox