Devicetree
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Georgi Valkov" <gvalkov@gmail.com>
Cc: robh@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v5 2/3] ARM: dts: armada: WRT3200ACM: add marvell,ignore-regulatory-hint
Date: Mon, 17 Aug 2026 22:05:03 +0000	[thread overview]
Message-ID: <20260817220504.4674D1F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260817215428.84740-2-gvalkov@gmail.com>

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The commit adds the device tree property `marvell,ignore-regulatory-hint` to the WRT3200ACM DTS, but the corresponding parser and logic in the `mwifiex` driver is missing from the tree.
--

--- Patch [2]: [PATCH v5 2/3] ARM: dts: armada: WRT3200ACM: add marvell,ignore-regulatory-hint ---
commit f221d0ed898a6646fd79f05bc58d44fefe8c2296
Author: Georgi Valkov <gvalkov@gmail.com>

ARM: dts: armada: WRT3200ACM: add marvell,ignore-regulatory-hint

This commit adds the marvell,ignore-regulatory-hint property to the WRT3200ACM
device tree. The property signals the mwifiex driver to ignore an incorrect
regulatory hint from the ROM, allowing userspace to set the correct platform
regulatory domain.

> diff --git a/arch/arm/boot/dts/marvell/armada-385-linksys-rango.dts b/arch/arm/boot/dts/marvell/armada-385-linksys-rango.dts
> index 4ab45f294de22..b93c5c419962f 100644
> --- a/arch/arm/boot/dts/marvell/armada-385-linksys-rango.dts
> +++ b/arch/arm/boot/dts/marvell/armada-385-linksys-rango.dts
> @@ -165,6 +165,15 @@ &sdhci {
>  	wp-inverted;
>  	bus-width = <8>;
>  	status = "okay";
> +
> +	#address-cells = <1>;
> +	#size-cells = <0>;
> +
> +	wifi@1 {
> +		compatible = "marvell,sd8897";
> +		reg = <1>;
> +		marvell,ignore-regulatory-hint;

[Severity: Medium]
Is the corresponding parser and logic for this property missing from the kernel
tree?

It doesn't appear there is any support for the marvell,ignore-regulatory-hint
property added to wifi@1 in the mainline mwifiex driver. Since the property is
not parsed anywhere, the regulatory conflict won't be resolved and the 5 GHz
radio will remain restricted when booting with this device tree.

Are there plans to send a companion patch to the wireless tree to actually
implement this feature?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260817215428.84740-1-gvalkov@gmail.com?part=2

  reply	other threads:[~2026-08-17 22:05 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <anWWr80yAcOQaVVS@nxpwireless-Inspiron-14-Plus-7440>
2026-08-07 18:21 ` [PATCH v3 1/2] wifi: mwifiex: ignore ROM regulatory hint on WRT3200ACM/WRT32x Georgi Valkov
2026-08-07 18:21   ` [PATCH v3 2/2] ARM: dts: armada: WRT3200ACM: add marvell,ignore-regulatory-hint Georgi Valkov
2026-08-07 18:43     ` sashiko-bot
2026-08-07 18:37   ` [PATCH v3 1/2] wifi: mwifiex: ignore ROM regulatory hint on WRT3200ACM/WRT32x sashiko-bot
2026-08-07 18:39   ` Johannes Berg
2026-08-07 19:49     ` George Valkov
2026-08-10 18:30       ` Brian Norris
2026-08-14 12:50         ` [PATCH 1/3] dt-bindings: net: wireless: add flag marvell,ignore-regulatory-hint Georgi Valkov
2026-08-14 12:50           ` [PATCH 2/3] ARM: dts: armada: WRT3200ACM: add marvell,ignore-regulatory-hint Georgi Valkov
2026-08-14 13:00             ` sashiko-bot
2026-08-14 12:50           ` [PATCH 3/3] wifi: mwifiex: add dt flag to ignore incorrect ROM regulatory hint Georgi Valkov
2026-08-17  8:54           ` [PATCH 1/3] dt-bindings: net: wireless: add flag marvell,ignore-regulatory-hint Krzysztof Kozlowski
2026-08-17 10:43             ` George Valkov
2026-08-17 11:06               ` Krzysztof Kozlowski
2026-08-17 13:20                 ` George Valkov
2026-08-17 13:24                   ` Krzysztof Kozlowski
2026-08-17 13:48                     ` George Valkov
2026-08-17 21:54                       ` [PATCH v5 " Georgi Valkov
2026-08-17 21:54                         ` [PATCH v5 2/3] ARM: dts: armada: WRT3200ACM: add marvell,ignore-regulatory-hint Georgi Valkov
2026-08-17 22:05                           ` sashiko-bot [this message]
2026-08-17 21:54                         ` [PATCH v5 3/3] wifi: mwifiex: add dt flag to ignore incorrect ROM regulatory hint Georgi Valkov
2026-08-18  0:53                         ` [PATCH v5 1/3] dt-bindings: net: wireless: add flag marvell,ignore-regulatory-hint Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260817220504.4674D1F000E9@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gvalkov@gmail.com \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox