From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2A87E3A9002; Tue, 18 Aug 2026 08:15:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787040960; cv=none; b=iJKQ4Y7MP2k2V648eLgkvgWs/EGPL0998PWeXp7ZJuWqMTSOOrYmbwUjjtrIb+g1uQxIZlp8SW7V2NGcomcW7ZsvyAvEx0Hemol8gmCgJLpek3bryQ2mvQZz9eGu7eOQRkjn5T5FwOjsOOKOjM/TlbfUa50uC6lcjlNmspFM/Gk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787040960; c=relaxed/simple; bh=kaqtj3HbmRIiFZrn9WlTzb8vRnqLFWcZRpAJGN7hdiA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=UF2HUopGg2OgC20ZQLnXQiEMkLg6xXPnBo4dQTdWeWPYkfhiE/5Hykka38Ffox8pa5rpkPixfiEWW8E4zSsizikXVTPqPYdWr5xRqMGZCBy8W+o3nHCiyFECgbSDX7WRWfe8sk8EKQkhw6i4CqgIA357o8n9V+Ulnwc1IY48BSw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Xk/geg+w; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Xk/geg+w" Received: by smtp.kernel.org (Postfix) with ESMTPSA id BB55F1F000E9; Tue, 18 Aug 2026 08:15:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1787040958; bh=+twbnS8x+43vKdzheHsWDwA0dSiFFn5kkCZH2ejJPTw=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=Xk/geg+wnd2tgBOy7uUuxvOkOMcY9kU9dbvGJH4QIh+m/DVxet3ogHq1bEIM6OQ2o ThxxXMCpZxPA0xCmYDrkDxQOnT5iGSq2Xo4VPrUhTYpAE/S2721vHfRbqfiMmZ66f4 tyf0qMPZn20fZ0G2AnH7OejTOhZUKEeqfVWWJ7xwyiKi0V/pm5WQkToFWiUhdCjnq4 6UJp8KF1Pd67RG+OmaPuuL8kIhWdYSZKKs6rmNbPgFF0rVn2PCUdztGEoz3h4wJ34K aFBJ11WBOmloh7LkkTZDdRd3XdA26BUItA3dL97ZUYzHyFVcVpgrX8yyUfYxlLfGrL dON8H0AQAcwGg== Date: Tue, 18 Aug 2026 10:15:54 +0200 From: Krzysztof Kozlowski To: Marek Vasut Cc: linux-usb@vger.kernel.org, Pankaj Dev , =?utf-8?Q?Cl=C3=A9ment?= Le Goffic , Gatien Chevallier , Alexandre Torgue , Christian Bruel , Conor Dooley , Fabrice Gasnier , Greg Kroah-Hartman , Krzysztof Kozlowski , Maxime Coquelin , Neil Armstrong , Rahul Kumar , Rob Herring , Rosen Penev , Thinh Nguyen , Vinod Koul , devicetree@vger.kernel.org, kernel@dh-electronics.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com Subject: Re: [PATCH v2 5/9] dt-bindings: usb: dwc3: Document ST STM32MP2 DWC3 xHCI USB controller Message-ID: <20260818-brainy-burgundy-monkey-fc2a0d@quoll> References: <20260816213849.1044073-1-marex@nabladev.com> <20260816213849.1044073-6-marex@nabladev.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260816213849.1044073-6-marex@nabladev.com> On Sun, Aug 16, 2026 at 11:37:07PM +0200, Marek Vasut wrote: > +properties: > + compatible: > + const: st,stm32mp25-dwc3 > + > + reg: > + maxItems: 1 > + > + access-controllers: > + maxItems: 1 > + > + clocks: > + minItems: 3 > + maxItems: 3 > + > + clock-names: > + items: > + - const: ref > + - const: bus_early > + - const: suspend > + > + dr_mode: > + $ref: /schemas/types.yaml#/definitions/string > + enum: [host, peripheral, otg] > + > + interrupts: > + maxItems: 1 > + > + phys: > + minItems: 1 > + maxItems: 2 > + > + phy-names: > + minItems: 1 > + items: > + - const: usb2-phy > + - const: usb3-phy > + > + resets: > + minItems: 1 Hm? You keep coming with some odd style, not present in any other files. Where do you see such code - property followed by minItems alone? This applies to other places as well. > + > + st,syscfg: > + $ref: /schemas/types.yaml#/definitions/phandle-array > + description: Phandle to system configuration controller. > + items: > + - items: > + - description: phandle to syscfg > + - description: USB3DR control offset within syscfg > + > + st,enable-port-power-control: > + type: boolean > + description: Enable Host-Mode Port Power Control (bit-3 of capability param HCCPARAMS) Why wouldn't this be enavled always? Why is this a board-level property? > + > + st,ovrcur-active-low: Don't re-invent stuff: st,over-current-active-low > + type: boolean > + description: Over-Current signal polarity is active-low > + > + st,vbusen-active-low: > + type: boolean > + description: VBUS-ENABLE signal polarity is active-low > + > +required: > + - compatible > + - reg > + - clocks > + - clock-names > + - interrupts > + - phys > + - phy-names > + - resets > + - st,syscfg > + > +unevaluatedProperties: false So where did you reference any other schema - for properties here and for this unevaluatedProps? > + > +examples: > + - | > + #include > + #include > + #include > + > + usb3dr: usb@48300000 { Drop unused label > + compatible = "st,stm32mp25-dwc3"; > + reg = <0x48300000 0x100000>; > + clocks = <&rcc CK_KER_USB2PHY2>, <&rcc CK_BUS_USB3DR>, <&rcc CK_KER_USB2PHY2>; > + clock-names = "ref", "bus_early", "suspend"; > + interrupts = ; > + phys = <&usb2_phy>, <&usb3_phy>; > + phy-names = "usb2-phy", "usb3-phy"; > + resets = <&rcc USB3DR_R>; > + st,ovrcur-active-low; > + st,syscfg = <&syscfg 0x4800>; > + st,vbusen-active-low; > + }; > -- > 2.53.0 >