Re: [PATCH 2/3] arm64: dts: renesas: r9a09g047: Add USB2.0 support

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Device Tree nodes are not sorted by unit-address.
--

--- Patch [2]: [PATCH 2/3] arm64: dts: renesas: r9a09g047: Add USB2.0 support ---
commit d34912c9041670ddb50206c7be9fec96e890adfb
Author: Tommaso Merciai <tommaso.merciai.xr@bp.renesas.com>

arm64: dts: renesas: r9a09g047: Add USB2.0 support

This commit adds support for the USB2.0 channels on the Renesas RZ/G3E
SoC, including EHCI, OHCI, PHY, and reset control nodes.

> diff --git a/arch/arm64/boot/dts/renesas/r9a09g047.dtsi b/arch/arm64/boot/dts/renesas/r9a09g047.dtsi
> --- a/arch/arm64/boot/dts/renesas/r9a09g047.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r9a09g047.dtsi
> @@ -1773,6 +1773,130 @@ usb3_phy: usb-phy@15870000 {
>  			status = "disabled";
>  		};
>  
> +		ohci0: usb@15800000 {
> +			compatible = "generic-ohci";

[ ... ]

> +		ohci1: usb@15810000 {
> +			compatible = "generic-ohci";

[ ... ]

> +		ehci0: usb@15800100 {

[Severity: Low]
This isn't a bug, but should these newly added device tree nodes be sorted by
their unit-address?

The new nodes (starting with usb@15800000) are appended after the existing
usb-phy@15870000 node, which breaks the ascending unit-address order.

Additionally, within the new block itself, the nodes appear to be grouped by
peripheral type rather than being sorted numerically by their unit-address,
resulting in usb@15810000 being placed before usb@15800100.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1787062965.git.tommaso.merciai.xr@bp.renesas.com?part=2