Re: [PATCH] dt-bindings: arm: ti,omap-mpu: Convert to DT schema

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The `sram` property in the DT schema is missing a `maxItems: 1` constraint, allowing an unbounded number of phandles.
--

--- Patch [1]: [PATCH] dt-bindings: arm: ti,omap-mpu: Convert to DT schema ---
commit 999724263c1ab03e517bff5216bcbf149a14a6a9
Author: Bhargav Joshi <j.bhargav.u@gmail.com>
Date:   Tue Aug 18 17:59:51 2026 +0000

dt-bindings: arm: ti,omap-mpu: Convert to DT schema

Convert TI OMAP Main Processor Unit MPU text to DT schema. This conversion
marks ti,hwmods as deprecated and preserves the existing pm-sram property
name to maintain backward compatibility.

> diff --git a/Documentation/devicetree/bindings/arm/ti/ti,omap-mpu.yaml b/Documentation/devicetree/bindings/arm/ti/ti,omap-mpu.yaml
> new file mode 100644
> index 0000000000000..abd8c64e8e9f7
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/arm/ti/ti,omap-mpu.yaml
> @@ -0,0 +1,58 @@

[ ... ]

> +  ti,hwmods:
> +    $ref: /schemas/types.yaml#/definitions/string
> +    description: Name of the hwmod associated with the MPU
> +    const: mpu
> +    deprecated: true
> +
> +  sram:
> +    description: ocmcram node
> +

[Severity: Low]
Does the sram property need a maxItems: 1 constraint here?

Without it, the device tree schema validator can allow an unbounded number of
phandles to be specified. Since the original binding indicated a single phandle
for the ocmcram node, adding maxItems: 1 would ensure dtbs_check correctly
rejects invalid device trees with multiple sram phandles.

> +  pm-sram:
> +    $ref: /schemas/types.yaml#/definitions/phandle-array

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260818-ti-mpu-v1-1-5b1c71a34669@gmail.com?part=1