From: Faruque Ansari <faruque.ansari@oss.qualcomm.com>
To: Oleksij Rempel <o.rempel@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Sebastian Reichel <sre@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
Guenter Roeck <linux@roeck-us.net>,
Benson Leung <bleung@chromium.org>,
Tzung-Bi Shih <tzungbi@kernel.org>,
Srinivas Kandagatla <srini@kernel.org>,
Daniel Lezcano <daniel.lezcano@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-watchdog@vger.kernel.org, kernel@pengutronix.de,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Mark Brown" <broonie@kernel.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
"Zhang Rui" <rui.zhang@intel.com>,
"Lukasz Luba" <lukasz.luba@arm.com>,
"Søren Andersen" <san@skov.dk>,
"Guenter Roeck" <groeck@chromium.org>,
"Matti Vaittinen" <mazziesaccount@gmail.com>,
"Ahmad Fatoum" <a.fatoum@pengutronix.de>,
"Andrew Morton" <akpm@linux-foundation.org>,
avaneesh.dwivedi@oss.qualcomm.com,
"Umang Chheda" <umang.chheda@oss.qualcomm.com>,
"Faruque Ansari" <faruque.ansari@oss.qualcomm.com>
Subject: [PATCH v2 2/4] power: reset: add PSCRR NVMEM recorder
Date: Wed, 19 Aug 2026 22:50:44 +0530 [thread overview]
Message-ID: <20260819-pscrr-provider-v2-2-9072383e0f4d@oss.qualcomm.com> (raw)
In-Reply-To: <20260819-pscrr-provider-v2-0-9072383e0f4d@oss.qualcomm.com>
Record the power state change reason into a small NVMEM cell (an RTC
scratch register or EEPROM) and read it back on the next boot, so the
cause survives a power cycle. The cell is a plain nvmem consumer
reference and the reason value is stored directly.
Co-developed-by: Oleksij Rempel <o.rempel@pengutronix.de>
Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
Signed-off-by: Faruque Ansari <faruque.ansari@oss.qualcomm.com>
---
drivers/power/reset/pscrr/Kconfig | 14 +++
drivers/power/reset/pscrr/Makefile | 1 +
drivers/power/reset/pscrr/pscrr-nvmem.c | 154 ++++++++++++++++++++++++++++++++
3 files changed, 169 insertions(+)
diff --git a/drivers/power/reset/pscrr/Kconfig b/drivers/power/reset/pscrr/Kconfig
index 72de82731b53..bfcf04b0c8f5 100644
--- a/drivers/power/reset/pscrr/Kconfig
+++ b/drivers/power/reset/pscrr/Kconfig
@@ -31,3 +31,17 @@ menuconfig PSCRR
unless hardware provides the reset cause.
If unsure, say N.
+
+if PSCRR
+
+config PSCRR_NVMEM
+ tristate "PSCRR NVMEM recorder provider"
+ depends on NVMEM
+ help
+ PSCRR recorder that stores the power state change reason in a
+ small NVMEM cell (such as an RTC scratch register) and reads it
+ back on the next boot, so the cause survives a power cycle.
+
+ If unsure, say N.
+
+endif # PSCRR
diff --git a/drivers/power/reset/pscrr/Makefile b/drivers/power/reset/pscrr/Makefile
index e5530a858971..95c80c80c7da 100644
--- a/drivers/power/reset/pscrr/Makefile
+++ b/drivers/power/reset/pscrr/Makefile
@@ -1,2 +1,3 @@
# SPDX-License-Identifier: GPL-2.0
obj-$(CONFIG_PSCRR) += pscrr.o
+obj-$(CONFIG_PSCRR_NVMEM) += pscrr-nvmem.o
diff --git a/drivers/power/reset/pscrr/pscrr-nvmem.c b/drivers/power/reset/pscrr/pscrr-nvmem.c
new file mode 100644
index 000000000000..1c3145c0d058
--- /dev/null
+++ b/drivers/power/reset/pscrr/pscrr-nvmem.c
@@ -0,0 +1,154 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * pscrr-nvmem.c - NVMEM recorder provider for PSCRR
+ *
+ * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
+ * Copyright (C) 2025 Pengutronix, Oleksij Rempel <o.rempel@pengutronix.de>
+ */
+
+#include <linux/module.h>
+#include <linux/nvmem-consumer.h>
+#include <linux/platform_device.h>
+#include <linux/pscrr.h>
+#include <linux/reboot.h>
+#include <linux/slab.h>
+
+struct pscrr_nvmem {
+ struct nvmem_cell *cell;
+ enum psc_reason reason;
+};
+
+static int pscrr_nvmem_cell_read(struct pscrr_nvmem *priv, u8 *out)
+{
+ size_t len;
+ void *buf;
+
+ buf = nvmem_cell_read(priv->cell, &len);
+ if (IS_ERR(buf))
+ return PTR_ERR(buf);
+
+ *out = len ? *(u8 *)buf : 0;
+ kfree(buf);
+
+ return 0;
+}
+
+static int pscrr_nvmem_cell_write(struct pscrr_nvmem *priv, u8 val)
+{
+ int ret;
+
+ /* nvmem_cell_write() returns the byte count on success, not 0. */
+ ret = nvmem_cell_write(priv->cell, &val, sizeof(val));
+
+ return ret < 0 ? ret : 0;
+}
+
+static int pscrr_nvmem_read_reasons(struct pscrr_provider *p,
+ unsigned long *reasons)
+{
+ struct pscrr_nvmem *priv = p->priv;
+
+ /*
+ * Report the reason latched at probe (or overwritten by a later
+ * record); the cell itself was cleared at probe, so it is not read
+ * live here.
+ */
+ set_bit(READ_ONCE(priv->reason), reasons);
+
+ return 0;
+}
+
+static int pscrr_nvmem_write_reason(struct pscrr_provider *p,
+ enum psc_reason reason)
+{
+ struct pscrr_nvmem *priv = p->priv;
+ int ret;
+
+ if (reason >= PSCR_REASON_COUNT)
+ return -EINVAL;
+
+ ret = pscrr_nvmem_cell_write(priv, reason);
+ if (ret)
+ return ret;
+
+ WRITE_ONCE(priv->reason, reason);
+
+ return 0;
+}
+
+static const struct pscrr_provider_ops pscrr_nvmem_ops = {
+ .read_reasons = pscrr_nvmem_read_reasons,
+ .write_reason = pscrr_nvmem_write_reason,
+};
+
+static int pscrr_nvmem_probe(struct platform_device *pdev)
+{
+ struct device *dev = &pdev->dev;
+ struct pscrr_nvmem *priv;
+ size_t bytes, bits;
+ u8 val;
+ int ret;
+
+ priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
+ if (!priv)
+ return -ENOMEM;
+
+ priv->cell = devm_nvmem_cell_get(dev, "pscr");
+ if (IS_ERR(priv->cell))
+ return dev_err_probe(dev, PTR_ERR(priv->cell),
+ "failed to get the pscr nvmem cell\n");
+
+ ret = nvmem_cell_get_size(priv->cell, &bytes, &bits);
+ if (ret)
+ return ret;
+
+ /* The reason is a single byte; a bit cell still occupies one. */
+ if ((bytes ?: DIV_ROUND_UP(bits, 8)) != sizeof(val))
+ return dev_err_probe(dev, -EINVAL,
+ "unsupported pscr nvmem cell size\n");
+
+ /*
+ * The cell survives resets, so at boot it still holds whatever the
+ * previous session recorded before it went down. Latch that as this
+ * boot's reason, then clear the cell back to PSCR_UNKNOWN: if this
+ * session is later cut short by an abrupt reset that never runs the
+ * recorder (watchdog power-cycle, sudden power loss), the next boot
+ * reads "unknown" instead of a stale reason left over from an earlier
+ * cycle.
+ */
+ ret = pscrr_nvmem_cell_read(priv, &val);
+ if (ret)
+ return dev_err_probe(dev, ret,
+ "failed to read the pscr nvmem cell\n");
+
+ priv->reason = val < PSCR_REASON_COUNT ? val : PSCR_UNKNOWN;
+
+ ret = pscrr_nvmem_cell_write(priv, PSCR_UNKNOWN);
+ if (ret)
+ return dev_err_probe(dev, ret,
+ "failed to clear the pscr nvmem cell\n");
+
+ return PTR_ERR_OR_ZERO(devm_pscrr_provider_register(dev, "nvmem",
+ &pscrr_nvmem_ops, NULL,
+ priv));
+}
+
+static const struct of_device_id pscrr_nvmem_of_match[] = {
+ { .compatible = "pscrr-nvmem" },
+ { }
+};
+MODULE_DEVICE_TABLE(of, pscrr_nvmem_of_match);
+
+static struct platform_driver pscrr_nvmem_driver = {
+ .probe = pscrr_nvmem_probe,
+ .driver = {
+ .name = "pscrr-nvmem",
+ .of_match_table = pscrr_nvmem_of_match,
+ },
+};
+module_platform_driver(pscrr_nvmem_driver);
+
+MODULE_AUTHOR("Oleksij Rempel <o.rempel@pengutronix.de>");
+MODULE_AUTHOR("Faruque Ansari <faruque.ansari@oss.qualcomm.com>");
+MODULE_DESCRIPTION("NVMEM recorder provider for PSCRR");
+MODULE_LICENSE("GPL");
--
2.34.1
next prev parent reply other threads:[~2026-08-19 17:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-19 17:20 [PATCH v2 0/4] power: reset: add NVMEM recorder provider for PSCRR Faruque Ansari
2026-08-19 17:20 ` [PATCH v2 1/4] dt-bindings: power: reset: add PSCRR NVMEM recorder binding Faruque Ansari
2026-08-27 9:45 ` Krzysztof Kozlowski
2026-08-19 17:20 ` Faruque Ansari [this message]
2026-08-19 17:20 ` [PATCH v2 3/4] nvmem: provide consumer access to cell size metrics Faruque Ansari
2026-08-19 17:20 ` [PATCH v2 4/4] arm64: dts: qcom: lemans: Add PSCRR NVMEM recorder node Faruque Ansari
2026-08-19 18:55 ` Abel Vesa
2026-08-24 9:17 ` Faruque Ansari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260819-pscrr-provider-v2-2-9072383e0f4d@oss.qualcomm.com \
--to=faruque.ansari@oss.qualcomm.com \
--cc=a.fatoum@pengutronix.de \
--cc=akpm@linux-foundation.org \
--cc=avaneesh.dwivedi@oss.qualcomm.com \
--cc=bleung@chromium.org \
--cc=broonie@kernel.org \
--cc=daniel.lezcano@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=groeck@chromium.org \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lukasz.luba@arm.com \
--cc=mazziesaccount@gmail.com \
--cc=o.rempel@pengutronix.de \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
--cc=rui.zhang@intel.com \
--cc=san@skov.dk \
--cc=sre@kernel.org \
--cc=srini@kernel.org \
--cc=tzungbi@kernel.org \
--cc=umang.chheda@oss.qualcomm.com \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox