From: Jonathan Cameron <jic23@kernel.org>
To: Taha Ed-Dafili <0rayn.dev@gmail.com>
Cc: lars@metafoo.de, Michael.Hennerich@analog.com, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org, dlechner@baylibre.com,
nuno.sa@analog.com, andy@kernel.org, skhan@linuxfoundation.org,
linux@analog.com, linux-iio@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 0/6] iio: dac: ad5504: bindings, cleanups, locking, and scale fixes
Date: Wed, 19 Aug 2026 02:29:24 +0100 [thread overview]
Message-ID: <20260819022924.2eee70c1@jic23-huawei> (raw)
In-Reply-To: <20260817211118.21833-1-0rayn.dev@gmail.com>
On Mon, 17 Aug 2026 17:11:09 -0400
Taha Ed-Dafili <0rayn.dev@gmail.com> wrote:
> This v4 series continues the cleanup and scale-fix work for the AD5504
> high-voltage DAC driver, addressing all outstanding feedback from the v3 review.
>
> Jonathan Cameron applied patches 2 (sort headers alphabetically) and 4
> (introduce local dev pointer) from v3 directly to iio/testing. This series
> rebases on top of that state and does not re-send those patches.
>
I took a look through and didn't have anything to add to Andy's
as normal excellent review. As he said, the patch descriptions are too
verbose. It can help to ask the AI to be terse in how it describes things
+ edit what comes out to drop any stuff that is too detailed.
Jonathan
prev parent reply other threads:[~2026-08-19 1:29 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-17 21:11 [PATCH v4 0/6] iio: dac: ad5504: bindings, cleanups, locking, and scale fixes Taha Ed-Dafili
2026-08-17 21:11 ` [PATCH v4 1/6] dt-bindings: iio: dac: ad5504: add output-range and missing gpios Taha Ed-Dafili
2026-08-17 21:11 ` [PATCH v4 2/6] iio: dac: ad5504: Align headers with IWYU principle Taha Ed-Dafili
2026-08-17 21:24 ` sashiko-bot
2026-08-18 4:43 ` Andy Shevchenko
2026-08-18 9:04 ` Uwe Kleine-König
2026-08-17 21:11 ` [PATCH v4 3/6] iio: dac: ad5504: remove legacy platform data support Taha Ed-Dafili
2026-08-17 21:23 ` sashiko-bot
2026-08-18 4:45 ` Andy Shevchenko
2026-08-19 8:22 ` Taha Ed-Dafili
2026-08-17 21:11 ` [PATCH v4 4/6] iio: dac: ad5504: introduce local lock to protect state and spi transfers Taha Ed-Dafili
2026-08-18 6:12 ` Andy Shevchenko
2026-08-18 8:36 ` Taha Ed-Dafili
2026-08-17 21:11 ` [PATCH v4 5/6] iio: dac: ad5504: strictly separate ACPI and DT probe paths Taha Ed-Dafili
2026-08-17 21:21 ` sashiko-bot
2026-08-18 6:26 ` Andy Shevchenko
2026-08-19 8:40 ` Taha Ed-Dafili
2026-08-17 21:11 ` [PATCH v4 6/6] iio: dac: ad5504: support scale via output-range-microvolt property Taha Ed-Dafili
2026-08-18 6:30 ` Andy Shevchenko
2026-08-18 8:23 ` Taha Ed-Dafili
2026-08-18 8:33 ` Andy Shevchenko
2026-08-19 1:29 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260819022924.2eee70c1@jic23-huawei \
--to=jic23@kernel.org \
--cc=0rayn.dev@gmail.com \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@analog.com \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox