Re: [PATCH v4 1/2] dt-bindings: usb: dwc3: Document Renesas R-Car Gen5 DWC3 xHCI USB controller

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Missing `phys` and `phy-names` property constraints in the local schema, allowing device trees with up to 19 PHYs to pass validation.
--

--- Patch [1]: [PATCH v4 1/2] dt-bindings: usb: dwc3: Document Renesas R-Car Gen5 DWC3 xHCI USB controller ---
commit cb2d4b4bfe0dea655c7acecc9fb3e13518b6d5fb
Author: Marek Vasut <marek.vasut+renesas@mailbox.org>

dt-bindings: usb: dwc3: Document Renesas R-Car Gen5 DWC3 xHCI USB controller

This commit documents the device tree bindings for the Renesas R-Car Gen5
DWC3 xHCI USB controller. It adds a new YAML schema referencing the generic
DWC3 common schema and defines local hardware constraints.

> diff --git a/Documentation/devicetree/bindings/usb/renesas,rcar-gen5-dwc3.yaml b/Documentation/devicetree/bindings/usb/renesas,rcar-gen5-dwc3.yaml
> new file mode 100644
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/renesas,rcar-gen5-dwc3.yaml
> @@ -0,0 +1,68 @@
[ ... ]
> +allOf:
> +  - $ref: snps,dwc3-common.yaml#
> +
> +properties:
> +  compatible:
> +    items:
> +      - const: renesas,r8a78000-dwc3
> +      - const: renesas,rcar-gen5-dwc3

[Severity: Low]
Should phys and phy-names constraints be included in this local properties
block?

The commit log mentions dropping generic phys/phy-names because of the
generic snps,dwc3-common.yaml reference. However, the generic schema permits
up to 19 PHYs.

Without local constraints (like maxItems: 2) specified in this block, the
schema would allow device trees with 3 or more PHYs to silently pass
validation, even though the hardware only supports 1 or 2.

> +
> +  reg:
> +    maxItems: 2

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260819050109.681890-1-marek.vasut+renesas@mailbox.org?part=1