From: sashiko-bot@kernel.org
To: "Prasad Kumpatla" <prasad.kumpatla@oss.qualcomm.com>
Cc: robh@kernel.org, devicetree@vger.kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v1 1/2] dt-bindings: arm: qcom: Add Maili SoC compatible
Date: Wed, 19 Aug 2026 05:51:52 +0000 [thread overview]
Message-ID: <20260819055153.59CAE1F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260819054203.61385-2-prasad.kumpatla@oss.qualcomm.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The new compatible string block for `qcom,maili` breaks the alphabetical sorting order of the SoC list.
--
--- Patch [1]: [PATCH v1 1/2] dt-bindings: arm: qcom: Add Maili SoC compatible ---
commit e26e69cd7b7d4cf716af221adce51d02ada71b52
Author: Yijie Yang <yijie.yang@oss.qualcomm.com>
dt-bindings: arm: qcom: Add Maili SoC compatible
This commit adds the qcom,maili SoC compatible string to the QCOM SoC
device tree bindings.
> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> index ff8a35df7862d..00d9a493fe766 100644
> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
[ ... ]
> @@ -175,6 +175,9 @@ properties:
> - qcom,kaanapali-qrd
> - const: qcom,kaanapali
>
> + - items:
> + - const: qcom,maili
> +
> - items:
> - enum:
> - qcom,mahua-crd
[Severity: Low]
This isn't a bug, but does this addition break the alphabetical sorting
of the compatible strings? It looks like qcom,maili is being placed
before qcom,mahua-crd, but 'i' comes after 'h'.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260819054203.61385-1-prasad.kumpatla@oss.qualcomm.com?part=1
next prev parent reply other threads:[~2026-08-19 5:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-19 5:42 [PATCH v1 0/2] Add initial Maili SoC support Prasad Kumpatla
2026-08-19 5:42 ` [PATCH v1 1/2] dt-bindings: arm: qcom: Add Maili SoC compatible Prasad Kumpatla
2026-08-19 5:50 ` Jingyi Wang
2026-08-19 6:04 ` Prasad Kumpatla
2026-08-19 5:51 ` sashiko-bot [this message]
2026-08-19 6:09 ` Krzysztof Kozlowski
2026-08-19 6:28 ` Yijie Yang
2026-08-19 6:35 ` Krzysztof Kozlowski
2026-08-19 7:02 ` Yijie Yang
2026-08-19 7:12 ` Krzysztof Kozlowski
2026-08-19 5:42 ` [PATCH v1 2/2] soc: qcom: pd-mapper: Add support for Maili SoC Prasad Kumpatla
2026-08-19 6:11 ` Krzysztof Kozlowski
2026-08-19 5:54 ` [PATCH v1 0/2] Add initial Maili SoC support Jingyi Wang
2026-08-19 6:04 ` Prasad Kumpatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260819055153.59CAE1F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=prasad.kumpatla@oss.qualcomm.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox