Re: [PATCH] dt-bindings: riscv: firmware: Add OpenSBI configuration binding

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 4 potential issue(s) to consider:
- [Low] The `maintainers` field in the YAML binding is empty, which causes dt_binding_check to fail.
- [Low] The `cold-boot-harts` property lacks an items definition for the phandle-array, leading to schema validation failures.
- [Low] Undefined phandle reference `&cpu0` in the example block causes a dtc compilation error.
- [Low] The `opensbi` vendor prefix is used in the compatible string but is not documented in `vendor-prefixes.yaml`.
--

--- Patch [1]: [PATCH] dt-bindings: riscv: firmware: Add OpenSBI configuration binding ---
commit 522fb80721bbecd24711af44482fc30a1ca8189e
Author: yangyinglu <yangyinglu@bosc.cn>

dt-bindings: riscv: firmware: Add OpenSBI configuration binding

This commit adds a Devicetree binding for OpenSBI configuration data in the
chosen node. It documents the opensbi,config compatible string and the
cold-boot-harts property used by the firmware during the boot phase.

> diff --git a/Documentation/devicetree/bindings/firmware/opensbi,config.yaml b/Documentation/devicetree/bindings/firmware/opensbi,config.yaml
> new file mode 100644
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/firmware/opensbi,config.yaml
> @@ -0,0 +1,38 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/firmware/opensbi,config.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: OpenSBI Firmware Configuration
> +
> +maintainers:
> +
> +description: |

[Severity: Low]
Is this missing a maintainer email? The YAML parser evaluates the empty
maintainers field as a null value, which violates the core.yaml meta-schema
constraint and causes make dt_binding_check to fail immediately.

> +  OpenSBI configuration data passed in the chosen node.
> +
> +properties:
> +  compatible:
> +    const: opensbi,config

[Severity: Low]
Should the opensbi vendor prefix be registered in vendor-prefixes.yaml?
Because this prefix is not registered, device tree tooling will emit an
unrecognized vendor prefix warning during validation.

> +
> +  cold-boot-harts:
> +    $ref: /schemas/types.yaml#/definitions/phandle-array
> +    description:

[Severity: Low]
Does this phandle-array need an explicit items constraint to indicate the
phandle entry takes zero arguments? 

Because cold-boot-harts is a phandle-array with a non-standard name,
dtschema will implicitly require the target cpu node to have a
#cold-boot-harts-cells property. Since CPU nodes do not define this,
validation will fail for valid device trees.

> +      List of hart CPU nodes selected as cold boot harts by OpenSBI.

[ ... ]

> +examples:
> +  - |
> +    / {
> +        chosen {
> +            opensbi-config {
> +                compatible = "opensbi,config";
> +                cold-boot-harts = <&cpu0>;

[Severity: Low]
Does the example block need a definition for the cpu0 label? 

When make dt_binding_check extracts and attempts to compile the example, it
will fail with a fatal reference to non-existent node or label error from
dtc since cpu0 isn't defined anywhere within the example.

> +            };
> +        };
> +    };
> +...

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260819090411.18561-1-guoyaxing@bosc.ac.cn?part=1