Devicetree
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Abel Vesa" <abel.vesa@oss.qualcomm.com>
Cc: linux-clk@vger.kernel.org, conor+dt@kernel.org,
	devicetree@vger.kernel.org, robh@kernel.org
Subject: Re: [PATCH 12/16] arm64: dts: qcom: sm8550: Add GCC CX power domain
Date: Wed, 19 Aug 2026 13:03:55 +0000	[thread overview]
Message-ID: <20260819130356.4D3461F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260819-qcom-tie-cx-to-gcc-v1-12-840034124e73@oss.qualcomm.com>

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Adding `power-domains` to the `qcom,sm8550-gcc` device tree node without updating the corresponding YAML binding causes a `dtbs_check` validation warning.
--

--- Patch [12]: [PATCH 12/16] arm64: dts: qcom: sm8550: Add GCC CX power domain ---
commit fbc80a89d2b6530024ab43fff461d5268dfeb3c4
Author: Abel Vesa <abel.vesa@oss.qualcomm.com>

arm64: dts: qcom: sm8550: Add GCC CX power domain

This commit adds a reference to the RPMh CX power domain for the GCC node
on SM8550. This ensures that consumer votes propagate properly.

> diff --git a/arch/arm64/boot/dts/qcom/sm8550.dtsi b/arch/arm64/boot/dts/qcom/sm8550.dtsi
> index 0e701e709235c..7137efb453467 100644
> --- a/arch/arm64/boot/dts/qcom/sm8550.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8550.dtsi
> @@ -1195,6 +1195,7 @@ gcc: clock-controller@100000 {
>  				 <&ufs_mem_phy 1>,
>  				 <&ufs_mem_phy 2>,
>  				 <&usb_dp_qmpphy QMP_USB43DP_USB3_PIPE_CLK>;
> +			power-domains = <&rpmhpd RPMHPD_CX>;

[Severity: Low]
Does this change require a corresponding update to the device tree bindings
YAML schema for qcom,sm8550-gcc?

Adding the power-domains property here without documenting it in the binding
schema will cause a dtbs_check validation warning.

>  		};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260819-qcom-tie-cx-to-gcc-v1-0-840034124e73@oss.qualcomm.com?part=12

  reply	other threads:[~2026-08-19 13:03 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-19 12:51 [PATCH 00/16] clk: qcom: Tie CX power domains to GCCs Abel Vesa
2026-08-19 12:51 ` [PATCH 01/16] clk: qcom: gcc-sm8250: Tie the CX power domain to controller Abel Vesa
2026-08-19 15:25   ` Konrad Dybcio
2026-08-19 12:51 ` [PATCH 02/16] clk: qcom: gcc-sm8350: " Abel Vesa
2026-08-19 13:12   ` sashiko-bot
2026-08-19 12:51 ` [PATCH 03/16] clk: qcom: gcc-sm8450: " Abel Vesa
2026-08-19 13:15   ` sashiko-bot
2026-08-19 12:51 ` [PATCH 04/16] clk: qcom: gcc-sm8550: " Abel Vesa
2026-08-19 12:51 ` [PATCH 05/16] clk: qcom: gcc-sm8650: " Abel Vesa
2026-08-19 12:51 ` [PATCH 06/16] clk: qcom: gcc-sm8750: " Abel Vesa
2026-08-19 12:51 ` [PATCH 07/16] clk: qcom: gcc-kaanapali: " Abel Vesa
2026-08-19 12:51 ` [PATCH 08/16] clk: qcom: gcc-qcs615: " Abel Vesa
2026-08-19 12:51 ` [PATCH 09/16] arm64: dts: qcom: sm8250: Add GCC CX power domain Abel Vesa
2026-08-19 13:08   ` sashiko-bot
2026-08-19 12:51 ` [PATCH 10/16] arm64: dts: qcom: sm8350: " Abel Vesa
2026-08-19 13:05   ` sashiko-bot
2026-08-19 12:51 ` [PATCH 11/16] arm64: dts: qcom: sm8450: " Abel Vesa
2026-08-19 12:51 ` [PATCH 12/16] arm64: dts: qcom: sm8550: " Abel Vesa
2026-08-19 13:03   ` sashiko-bot [this message]
2026-08-19 12:51 ` [PATCH 13/16] arm64: dts: qcom: sm8650: " Abel Vesa
2026-08-19 13:09   ` sashiko-bot
2026-08-19 12:51 ` [PATCH 14/16] arm64: dts: qcom: sm8750: " Abel Vesa
2026-08-19 12:52 ` [PATCH 15/16] arm64: dts: qcom: kaanapali: " Abel Vesa
2026-08-19 12:52 ` [PATCH 16/16] arm64: dts: qcom: talos: " Abel Vesa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260819130356.4D3461F000E9@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=abel.vesa@oss.qualcomm.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox