Re: [PATCH 1/8] dt-bindings: remoteproc: qcom,nord-pas: Add qcom,cluster-root property

[Krzysztof Kozlowski <krzk@kernel.org>]

On Sat, Aug 15, 2026 at 09:25:34PM +0800, Shawn Guo wrote:
> Document the qcom,cluster-root phandle property used to describe HPASS's
> ADSP0/1/2 cluster relationship. Every member of a cluster carries the
> property, including the instance owning the shared resources, which
> references itself; instances referencing the same node form one cluster
> that boots in order and is torn down as a single unit.
> 
> The relationship is described with a phandle rather than by containment
> in a parent node, as ti,k3-r5f-rproc and xlnx,zynqmp-r5fss do, because
> the hardware does not express it by containment either: the three QDSP6SS
> blocks are register-independent, with no shared register window for a
> container node to describe.
> 
> Also add the qcom,nord-adsp1-pas and qcom,nord-adsp2-pas compatible
> strings used by the non-root cluster members.
> 
> Assisted-by: LLM
> Signed-off-by: Shawn Guo <shengchao.guo@oss.qualcomm.com>
> ---
>  .../bindings/remoteproc/qcom,nord-pas.yaml      | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,nord-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,nord-pas.yaml
> index e90d2953ba69..58d88cb07e52 100644
> --- a/Documentation/devicetree/bindings/remoteproc/qcom,nord-pas.yaml
> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,nord-pas.yaml
> @@ -17,6 +17,8 @@ properties:
>    compatible:
>      enum:
>        - qcom,nord-adsp-pas
> +      - qcom,nord-adsp1-pas
> +      - qcom,nord-adsp2-pas
>        - qcom,nord-cdsp0-pas
>        - qcom,nord-cdsp1-pas
>        - qcom,nord-cdsp2-pas
> @@ -89,6 +91,19 @@ properties:
>      maxItems: 1
>      description: The names of the state bits used for SMP2P output
>  
> +  qcom,cluster-root:
> +    $ref: /schemas/types.yaml#/definitions/phandle
> +    description:
> +      Reference to the Peripheral Authentication Service instance that owns the
> +      resources shared across this DSP's cluster. HPASS shares clock/reset/NoC
> +      resources between its ADSP0/1/2 QDSP6 instances, and the owning instance
> +      (ADSP0) has to boot first to initialize them before ADSP1/ADSP2 can cold

This feels way too much SW. We design hardware resources in
owner-independent, meaning each device is the owner. Most of Linux
frameworks, including listed clock, reset and ICC, support resource
sharing for multi-owner case.


If this is not SW related, then I claim that compatible defines whether
services is owner of the hardware or not.

Also, unresponded Sashiko comments.

Best regards,
Krzysztof