Re: [PATCH v8 5/5] iio: osf: add UART IIO driver

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] Hardware Initialization Order: Regulator enabled before UART is configured, risking loss of initial capability report.
--

--- Patch [5]: [PATCH v8 5/5] iio: osf: add UART IIO driver ---
commit 9c6fb720e1ae8c10cafcfaeb63c04248f654050d
Author: Jinseob Kim <kimjinseob88@gmail.com>

iio: osf: add UART IIO driver

This commit adds the Open Sensor Fusion (OSF) UART IIO driver. It handles
receiving OSF frames over a serdev UART, registers IIO devices based on
capability reports, and exposes sensor samples via direct reads and buffers.

> diff --git a/drivers/iio/opensensorfusion/osf_serdev.c b/drivers/iio/opensensorfusion/osf_serdev.c
> --- /dev/null
> +++ b/drivers/iio/opensensorfusion/osf_serdev.c

[ ... ]

> +static int osf_serdev_probe(struct serdev_device *serdev)
> +{

[ ... ]

> +	serdev_device_set_drvdata(serdev, osf_uart);
> +	serdev_device_set_client_ops(serdev, &osf_serdev_ops);
> +
> +	ret = devm_regulator_get_enable(dev, "vcc");
> +	if (ret)
> +		return dev_err_probe(dev, ret,
> +				     "failed to enable vcc regulator\n");
> +
> +	ret = serdev_device_open(serdev);
> +	if (ret)
> +		return ret;
> +
> +	baudrate = serdev_device_set_baudrate(serdev, OSF_SERDEV_BAUD);

[Severity: High]
Could this hardware initialization order lead to a race condition where the
sensor's initial capability report is lost?

Since the vcc regulator is enabled before the serdev UART port is opened
and its baud rate configured, if the sensor boots quickly and transmits
its capability report immediately upon power-up, the host UART might not
be ready to receive it. 

Because the driver relies on autonomously transmitted capability reports to
register IIO devices, missing this initial report could leave the driver
completely non-functional.

Would it be safer to open and configure the serdev UART before enabling
the regulator?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260820050608.5440-1-kimjinseob88@gmail.com?part=5