Re: [PATCH v6 1/2] dt-bindings: iio: adc: ti,ads112c04: Add binding for ADS112C04

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The `excitation-current-nanoamp` property incorrectly uses a scalar `enum` constraint instead of an `items` list, preventing the valid use of multiple excitation channels in the device tree.
--

--- Patch [1]: [PATCH v6 1/2] dt-bindings: iio: adc: ti,ads112c04: Add binding for ADS112C04 ---
commit ad41025959acbdcfe32933f6e12d580d2924bc04
Author: Kyle Hsieh <kylehsieh1995@gmail.com>

dt-bindings: iio: adc: ti,ads112c04: Add binding for ADS112C04

This commit adds device tree binding documentation for Texas Instruments
ADS112C04 I2C Analog-to-Digital Converters. It outlines the hardware
capabilities including the flexible input multiplexer, programmable gain
amplifier, and programmable excitation current sources.

> diff --git a/Documentation/devicetree/bindings/iio/adc/ti,ads112c04.yaml b/Documentation/devicetree/bindings/iio/adc/ti,ads112c04.yaml
> new file mode 100644
> index 0000000000000..81b3511139f3c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/adc/ti,ads112c04.yaml

[ ... ]

> +      excitation-channels:
> +        maxItems: 2
> +        items:
> +          maximum: 5
> +        description:
> +          Additionally to AIN0-AIN3, IDAC1/IDAC2 can also be routed to
> +          REFP0 (4) and REFN0 (5).
> +
> +      excitation-current-nanoamp:
> +        enum: [10000, 50000, 100000, 250000, 500000, 1000000, 1500000]

[Severity: Low]
Does this restrict the property to a single scalar value? 

Since excitation-channels allows up to two items, wouldn't
excitation-current-nanoamp also need to allow an array (for example, by
using maxItems: 2 and placing the enum inside an items constraint) so that
configurations defining two excitation currents can pass schema validation?

> +
> +      burn-out-current-nanoamp:
> +        const: 10000

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260820-ti-ads112c04-driver-v6-0-0e8f0aacce9b@gmail.com?part=1