Re: [PATCH v8 15/16] arm64: dts: st: support Engicam MicroGEA-STM32MP257D-RMM board

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The GPIO LED nodes ('led-0', 'led-1') lack 'color' and 'function' properties, which are required for correct sysfs directory naming by user-space LED managers.
--

--- Patch [15]: [PATCH v8 15/16] arm64: dts: st: support Engicam MicroGEA-STM32MP257D-RMM board ---
commit 8abcb6fbdc6467a93764ff0fd12f19a18a0215bf
Author: Dario Binacchi <dario.binacchi@amarulasolutions.com>

arm64: dts: st: support Engicam MicroGEA-STM32MP257D-RMM board

This commit adds device tree support for the Engicam MicroGEA-STM32MP257D-RMM
board. It enables various peripherals including LEDs, CAN, a touchscreen panel,
and audio components.

> diff --git a/arch/arm64/boot/dts/st/stm32mp257d-engicam-microgea-rmm.dts b/arch/arm64/boot/dts/st/stm32mp257d-engicam-microgea-rmm.dts
> new file mode 100644
> index 0000000000000..f5af0913bf1b8
> --- /dev/null
> +++ b/arch/arm64/boot/dts/st/stm32mp257d-engicam-microgea-rmm.dts

[ ... ]

> +	leds {
> +		compatible = "gpio-leds";
> +
> +		led-0 {
> +			gpios = <&gpioh 2 GPIO_ACTIVE_HIGH>;
> +			default-state = "off";
> +			status = "okay";
> +		};

[Severity: Medium]
Should this node include color and function properties? 

Modern user-space LED managers rely on these properties to create standard 
sysfs directories named <color>:<function>. Without them, the LED will be 
exported with the non-standard name led-0, which can prevent user-space from 
correctly identifying its hardware role.

> +
> +		led-1 {
> +			gpios = <&gpioh 6 GPIO_ACTIVE_HIGH>;
> +			default-state = "off";
> +			status = "okay";
> +		};

[Severity: Medium]
Similarly, does this node also need color and function properties instead of
relying on the led-1 node name for sysfs directory creation?

> +	};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260820091652.43541-1-dario.binacchi@amarulasolutions.com?part=15