Re: [PATCH 3/7] rust: crc_ccitt: add CRC-CCITT abstraction

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Missing import for `bindings` in `crc_ccitt.rs`, leading to a compilation failure when `CONFIG_RUST_CRC_CCITT_ABSTRACTIONS=y`.
--

--- Patch [3]: [PATCH 3/7] rust: crc_ccitt: add CRC-CCITT abstraction ---
commit 07276b496fabcc3fbd341c5cd0116734faf9ec26
Author: Ayush Singh <ayush@beagleboard.org>

rust: crc_ccitt: add CRC-CCITT abstraction

This commit adds a Rust abstraction for the CRC-CCITT library functions. The
module is gated behind the new CONFIG_RUST_CRC_CCITT_ABSTRACTIONS Kconfig
symbol so the C library is only built when required by a Rust user.

> diff --git a/rust/kernel/crc_ccitt.rs b/rust/kernel/crc_ccitt.rs
> new file mode 100644
> index 0000000000000..6042ada16967d
> --- /dev/null
> +++ b/rust/kernel/crc_ccitt.rs
[ ... ]
> +#[inline]
> +pub fn crc_ccitt(crc: u16, data: &[u8]) -> u16 {
> +    // SAFETY: `data.as_ptr()` is valid for reads of `data.len()` bytes for the
> +    // duration of the call, since it is derived from a live shared slice.
> +    unsafe { bindings::crc_ccitt(crc, data.as_ptr(), data.len()) }

[Severity: Low]
Does this code fail to compile when CONFIG_RUST_CRC_CCITT_ABSTRACTIONS=y?
It looks like the bindings module is not imported in this file, which
would cause a build failure when resolving bindings::crc_ccitt here.

> +}

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260820-gb-uart-transport-v1-0-282da14ab7b7@beagleboard.org?part=3