Devicetree
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Abel Vesa" <abel.vesa@oss.qualcomm.com>
Cc: conor+dt@kernel.org, devicetree@vger.kernel.org, robh@kernel.org,
	linux-clk@vger.kernel.org
Subject: Re: [PATCH v2 09/16] arm64: dts: qcom: sm8250: Add GCC CX power domain
Date: Thu, 20 Aug 2026 10:20:49 +0000	[thread overview]
Message-ID: <20260820102049.D08011F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260820-qcom-tie-cx-to-gcc-v2-9-e67ea30d8b7b@oss.qualcomm.com>

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] DT Binding Violation: The `power-domains` property is added to the `gcc` node but is not documented in the corresponding `qcom,gcc-sm8250.yaml` DT binding schema.
--

--- Patch [9]: [PATCH v2 09/16] arm64: dts: qcom: sm8250: Add GCC CX power domain ---
commit 734b5cf106da5d46876e8b4bb05d32739432959a
Author: Abel Vesa <abel.vesa@oss.qualcomm.com>

arm64: dts: qcom: sm8250: Add GCC CX power domain

This commit adds the RPMh CX power domain reference to the GCC node in the
SM8250 device tree. This ensures that votes from GCC GDSC consumers properly
propagate to the RPMh CX domain.

> diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi
> index 90f8b091634e9..50790cf1c3ca1 100644
> --- a/arch/arm64/boot/dts/qcom/sm8250.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi
> @@ -971,6 +971,7 @@ gcc: clock-controller@100000 {
>  			clocks = <&rpmhcc RPMH_CXO_CLK>,
>  				 <&rpmhcc RPMH_CXO_CLK_A>,
>  				 <&sleep_clk>;
> +			power-domains = <&rpmhpd RPMHPD_CX>;

[Severity: Low]
Will running make dtbs_check produce a validation warning for this new
property?

Looking at Documentation/devicetree/bindings/clock/qcom,gcc-sm8250.yaml, the
binding enforces unevaluatedProperties: false but does not explicitly declare
power-domains.

Should the binding schema be updated alongside this change to allow
power-domains so we avoid build validation failures?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260820-qcom-tie-cx-to-gcc-v2-0-e67ea30d8b7b@oss.qualcomm.com?part=9

  reply	other threads:[~2026-08-20 10:20 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-20 10:07 [PATCH v2 00/16] clk: qcom: Tie CX power domains to GCCs Abel Vesa
2026-08-20 10:07 ` [PATCH v2 01/16] clk: qcom: gcc-sm8250: Tie the CX power domain to controller Abel Vesa
2026-08-20 10:25   ` sashiko-bot
2026-08-20 10:29   ` Konrad Dybcio
2026-08-20 10:07 ` [PATCH v2 02/16] clk: qcom: gcc-sm8350: " Abel Vesa
2026-08-20 10:29   ` Konrad Dybcio
2026-08-20 10:07 ` [PATCH v2 03/16] clk: qcom: gcc-sm8450: " Abel Vesa
2026-08-20 10:29   ` Konrad Dybcio
2026-08-20 10:07 ` [PATCH v2 04/16] clk: qcom: gcc-sm8550: " Abel Vesa
2026-08-20 10:29   ` Konrad Dybcio
2026-08-20 10:07 ` [PATCH v2 05/16] clk: qcom: gcc-sm8650: " Abel Vesa
2026-08-20 10:30   ` Konrad Dybcio
2026-08-20 10:07 ` [PATCH v2 06/16] clk: qcom: gcc-sm8750: " Abel Vesa
2026-08-20 10:25   ` sashiko-bot
2026-08-20 10:30   ` Konrad Dybcio
2026-08-20 10:07 ` [PATCH v2 07/16] clk: qcom: gcc-kaanapali: " Abel Vesa
2026-08-20 10:30   ` Konrad Dybcio
2026-08-20 10:07 ` [PATCH v2 08/16] clk: qcom: gcc-qcs615: " Abel Vesa
2026-08-20 10:27   ` sashiko-bot
2026-08-20 10:30   ` Konrad Dybcio
2026-08-20 10:07 ` [PATCH v2 09/16] arm64: dts: qcom: sm8250: Add GCC CX power domain Abel Vesa
2026-08-20 10:20   ` sashiko-bot [this message]
2026-08-20 10:07 ` [PATCH v2 10/16] arm64: dts: qcom: sm8350: " Abel Vesa
2026-08-20 10:19   ` sashiko-bot
2026-08-20 10:07 ` [PATCH v2 11/16] arm64: dts: qcom: sm8450: " Abel Vesa
2026-08-20 10:07 ` [PATCH v2 12/16] arm64: dts: qcom: sm8550: " Abel Vesa
2026-08-20 10:07 ` [PATCH v2 13/16] arm64: dts: qcom: sm8650: " Abel Vesa
2026-08-20 10:21   ` sashiko-bot
2026-08-20 10:07 ` [PATCH v2 14/16] arm64: dts: qcom: sm8750: " Abel Vesa
2026-08-20 10:07 ` [PATCH v2 15/16] arm64: dts: qcom: kaanapali: " Abel Vesa
2026-08-20 10:07 ` [PATCH v2 16/16] arm64: dts: qcom: talos: " Abel Vesa
2026-08-20 10:22   ` sashiko-bot
2026-08-20 10:44 ` [PATCH v2 00/16] clk: qcom: Tie CX power domains to GCCs Abel Vesa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260820102049.D08011F000E9@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=abel.vesa@oss.qualcomm.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox