From: sashiko-bot@kernel.org
To: "Konrad Dybcio" <konradybcio@kernel.org>
Cc: conor+dt@kernel.org, devicetree@vger.kernel.org, robh@kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: agatti: Flatten the USB node
Date: Thu, 20 Aug 2026 13:03:08 +0000 [thread overview]
Message-ID: <20260820130308.B61FA1F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260820-topic-agatti_flatten-v1-1-ba9dcab9dc2c@oss.qualcomm.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] Missing `dr_mode` and `maximum-speed` properties in the flattened USB node
--
--- Patch [1]: [PATCH] arm64: dts: qcom: agatti: Flatten the USB node ---
commit 0427bd1800c10434e0638f89470c4f8172cd92b9
Author: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
arm64: dts: qcom: agatti: Flatten the USB node
This commit updates the USB controller node in the agatti device tree
by flattening it to use the latest bindings and flattened driver approach.
> diff --git a/arch/arm64/boot/dts/qcom/agatti.dtsi b/arch/arm64/boot/dts/qcom/agatti.dtsi
> index 590bd2432d85b..e7fed60a59d93 100644
> --- a/arch/arm64/boot/dts/qcom/agatti.dtsi
> +++ b/arch/arm64/boot/dts/qcom/agatti.dtsi
[ ... ]
> @@ -1606,48 +1610,42 @@ &bimc SLAVE_EBI1 RPM_ALWAYS_TAG>,
[ ... ]
> - usb_dwc3: usb@4e00000 {
> - compatible = "snps,dwc3";
> - reg = <0x0 0x04e00000 0x0 0xcd00>;
> - interrupts = <GIC_SPI 255 IRQ_TYPE_LEVEL_HIGH>;
> - phys = <&usb_hsphy>, <&usb_qmpphy>;
> - phy-names = "usb2-phy", "usb3-phy";
> - iommus = <&apps_smmu 0x120 0x0>;
> - snps,dis_u2_susphy_quirk;
> - snps,dis_enblslpm_quirk;
> - snps,has-lpm-erratum;
> - snps,hird-threshold = /bits/ 8 <0x10>;
> - snps,usb3_lpm_capable;
> - snps,parkmode-disable-ss-quirk;
> - maximum-speed = "super-speed";
> - dr_mode = "otg";
> - usb-role-switch;
> + snps,hird-threshold = /bits/ 8 <0x10>;
> + snps,parkmode-disable-ss-quirk;
> + snps,dis_u2_susphy_quirk;
> + snps,dis_enblslpm_quirk;
> + snps,has-lpm-erratum;
> + snps,usb3_lpm_capable;
>
> + usb-role-switch;
> + wakeup-source;
>
> + status = "disabled";
[Severity: High]
Were the maximum-speed and dr_mode properties intentionally dropped when
flattening this node?
The previous usb_dwc3 child node defined dr_mode = "otg" and
maximum-speed = "super-speed", but they appear to be missing from the
newly flattened usb: usb@4e00000 node.
Could dropping dr_mode cause the USB controller to fail to initialize
role-switching properly and break OTG functionality on boards utilizing
this SoC?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260820-topic-agatti_flatten-v1-1-ba9dcab9dc2c@oss.qualcomm.com?part=1
prev parent reply other threads:[~2026-08-20 13:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-20 12:37 [PATCH] arm64: dts: qcom: agatti: Flatten the USB node Konrad Dybcio
2026-08-20 12:48 ` Abel Vesa
2026-08-20 13:03 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260820130308.B61FA1F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox