Re: [PATCH] arm64: dts: exynos850: Add GPU/Mali Bifrost node

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The newly introduced compatible string 'samsung,exynos850-mali' is not documented in the device tree bindings schema.
--

--- Patch [1]: [PATCH] arm64: dts: exynos850: Add GPU/Mali Bifrost node ---
commit 358cd68635088d124d51d9f2284625ff11e03e28
Author: Thomas Turner <tturner@lineageos.org>

arm64: dts: exynos850: Add GPU/Mali Bifrost node

This commit adds a GPU node for the Exynos850 platform to provide basic GPU
functionality. The panfrost driver can probe the Mali-G52 GPU with core
clocks set up, though advanced power management features are not yet
supported.

> diff --git a/arch/arm64/boot/dts/exynos/exynos850.dtsi b/arch/arm64/boot/dts/exynos/exynos850.dtsi
> index 3881f573ec08d..8ed85c125030a 100644
> --- a/arch/arm64/boot/dts/exynos/exynos850.dtsi
> +++ b/arch/arm64/boot/dts/exynos/exynos850.dtsi
> @@ -296,6 +296,18 @@ cmu_g3d: clock-controller@11400000 {
>  			clock-names = "oscclk", "dout_g3d_switch";
>  		};
>  
> +		gpu: gpu@11500000 {
> +			compatible = "samsung,exynos850-mali", "arm,mali-bifrost";

[Severity: Low]
Is the new compatible string samsung,exynos850-mali documented in the
device tree bindings schema?

It appears this SoC-specific compatible string lacks a corresponding entry in
the dt-bindings documentation (e.g.
Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml). This will
likely cause make dtbs_check to emit warnings or fail validation for this
device tree file.

> +			reg = <0x11500000 0x5000>;
[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260820133556.76300-1-tturner@lineageos.org?part=1