From: sashiko-bot@kernel.org
To: "Xianwei Zhao" <xianwei.zhao@amlogic.com>
Cc: robh@kernel.org, neil.armstrong@linaro.org,
linux-amlogic@lists.infradead.org, devicetree@vger.kernel.org,
conor+dt@kernel.org
Subject: Re: [PATCH v3 1/2] dt-bindings: thermal: amlogic: Add A9 thermal bindings
Date: Fri, 21 Aug 2026 07:57:57 +0000 [thread overview]
Message-ID: <20260821075758.4BF551F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260821-a9-thermal-v3-1-0e7abf3941e3@amlogic.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The commit message contains a typographical error, referring to the clock as 'plck' instead of 'pclk'.
--
--- Patch [1]: [PATCH v3 1/2] dt-bindings: thermal: amlogic: Add A9 thermal bindings ---
commit 49a4951362b7daffa63163bcd033f80c3c836b83
Author: Xianwei Zhao <xianwei.zhao@amlogic.com>
dt-bindings: thermal: amlogic: Add A9 thermal bindings
Document the thermal controller compatibles for the Amlogic A9 SoC. Describe
the required core and pclk clocks and update the schema constraints for the
A9-specific thermal controllers.
> Describe the required "core" and "plck" clocks, and update the schema
> constraints for A9-specific thermal controllers.
[Severity: Low]
This isn't a bug, but there is a typo in the commit message. The commit
message refers to the clock as "plck", while the binding schema correctly
defines it as "pclk".
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260821-a9-thermal-v3-0-0e7abf3941e3@amlogic.com?part=1
next prev parent reply other threads:[~2026-08-21 7:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-21 7:50 [PATCH v3 0/2] thermal: Add support A9 Xianwei Zhao via B4 Relay
2026-08-21 7:50 ` [PATCH v3 1/2] dt-bindings: thermal: amlogic: Add A9 thermal bindings Xianwei Zhao via B4 Relay
2026-08-21 7:57 ` sashiko-bot [this message]
2026-08-21 7:50 ` [PATCH v3 2/2] thermal: amlogic: Add support for A9 thermal controller Xianwei Zhao via B4 Relay
2026-08-21 8:01 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260821075758.4BF551F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=neil.armstrong@linaro.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=xianwei.zhao@amlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox