Re: [PATCH v1 1/3] dt-bindings: arm: fsl: add Variscite VAR-SOM-MX7 boards

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] Mismatch between commit message and schema definition regarding v2 WM8731 hardware configurations.
- [Low] YAML formatting violates the 'indent-sequences: true' rule, causing yamllint validation failures.
--

--- Patch [1]: [PATCH v1 1/3] dt-bindings: arm: fsl: add Variscite VAR-SOM-MX7 boards ---
commit 52d9fb69ce3c9933762d9090a8a1790cd333bffd
Author: Stefano Radaelli <stefano.r@variscite.com>

dt-bindings: arm: fsl: add Variscite VAR-SOM-MX7 boards

Add DT compatible strings for the Variscite VAR-SOM-MX7 SoM variants
used with the MX7CustomBoard carrier board.

> Both the first and second hardware revisions are supported, with
> eMMC, NAND and WM8731 configurations.

[Severity: Medium]
Does the v2 hardware revision actually support the WM8731 configurations?

The commit message states these configurations are supported for both hardware
revisions, but the expected compatible strings for v2 (such as
variscite,var-som-imx7d-v2-emmc-wm8731-mx7customboard and
variscite,var-som-imx7d-v2-nand-wm8731-mx7customboard) are omitted from the
v2 enum in the schema below.

> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> index 656f2596e1d53..20a225420d20b 100644
> --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
[ ... ]
> +      - description: i.MX7D Variscite Boards based on VAR-SOM-MX7 Module
> +        oneOf:
> +          - items:
> +            - enum:

[Severity: Low]
Will this formatting fail the kernel's yamllint checks during
make dt_binding_check?

The block sequences (- enum: and - const:) under the items: keys are
placed at the exact same indentation level as their parent mapping key. The
indent-sequences: true rule requires them to be indented further to pass
schema validation checks.

> +                - variscite,var-som-imx7d-emmc-mx7customboard
[ ... ]
> +          - items:
> +            - enum:
> +                - variscite,var-som-imx7d-v2-emmc-mx7customboard
> +                - variscite,var-som-imx7d-v2-nand-mx7customboard
> +            - const: variscite,var-som-imx7d-v2
> +            - const: fsl,imx7d

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1787314780.git.stefano.r@variscite.com?part=1