From: Jonathan Cameron <jic23@kernel.org>
To: Esben Haabendal <esben@geanix.com>
Cc: "David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Nikita Travkin" <nikita@trvn.ru>,
"Maslov Dmitry" <maslovdmitry@seeed.cc>,
"Kuppuswamy Sathyanarayanan"
<sathyanarayanan.kuppuswamy@linux.intel.com>,
"Thomas Gleixner" <tglx@kernel.org>,
"Pan Chuang" <panchuang@vivo.com>,
"Yangtao Li" <frank.li@vivo.com>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
"Krzysztof Kozlowski" <krzysztof.kozlowski@oss.qualcomm.com>,
stable@vger.kernel.org,
"Andy Shevchenko" <andriy.shevchenko@intel.com>
Subject: Re: [PATCH v5 0/8] iio: light: ltr501: Add ltr329 support
Date: Sun, 23 Aug 2026 00:40:24 +0100 [thread overview]
Message-ID: <20260823004024.015d66bf@jic23-huawei> (raw)
In-Reply-To: <20260817-liteon-ltr329-v5-0-6f71ab2b0588@geanix.com>
On Mon, 17 Aug 2026 19:08:49 +0200
Esben Haabendal <esben@geanix.com> wrote:
> The LiteON LTR-329ALS-01 chip is similar to the LTR-303ALS-01, except for
> interrupt support and related registers, which LTR-329ALS-01 does not have.
>
> Signed-off-by: Esben Haabendal <esben@geanix.com>
With tweaks to patch 4 and dropping 5, applied to the testing branch of iio.git
thanks,
Jonathan
> ---
> Changes in v5:
> - Changed error handling of interrupt being configured for ltr329 device to
> just print a warning message and get on with life.
> - Mark interrupt properties as invalid for liteon,ltr329 bindings.
> - Changed patch 5 to not claim to be a fix.
> - Link to v4: https://patch.msgid.link/20260810-liteon-ltr329-v4-0-8bd3dfd15280@geanix.com
>
> Changes in v4:
> - Split the duplicate error message removal into separate patch.
> - Removed uneeded enum =0 assignment.
> - Use dev_err_probe() instead of plain dev_err().
> - Link to v3: https://patch.msgid.link/20260804-liteon-ltr329-v3-0-c6b768c7c745@geanix.com
>
> Changes in v3:
> - Removed duplicated error message on devm_request_threaded_irq() failure.
> - Added Fixes: and Cc: stable tags to fix for error handling of
> devm_request_threaded_irq() failure.
> - Added no_irq_support boolean to simplify checking for chip irq support.
> - Moved check for no_irq_support from ltr501_read_intr_prst() and
> ltr501_write_intr_prst() to callers. Note: event functions are not
> registered for no_irq_support devices.
> - Moved #include <linux/array_size.h> into its place according to
> alphabetical sorting order (although the rest is not really wel sorted).
> - Restored alphanumerical ordering of compatible list in bindings
> documentation.
> - Ordered device arrays and enum values according to alphanumerical sorting
> order.
> - Link to v2: https://patch.msgid.link/20260715-liteon-ltr329-v2-0-d18af55edab5@geanix.com
>
> Changes in v2:
> - Fixed error handling when irq is defined for a chip that does not support
> irq, powering the chip down again.
> - Added simlar fix to error handling of devm_request_threaded_irq() error
> handling, powering the chip down again on failure.
> - Added explicit #include <linux/array_size.h>.
> - Link to v1: https://patch.msgid.link/20260715-liteon-ltr329-v1-0-31f027051594@geanix.com
>
> To: Jonathan Cameron <jic23@kernel.org>
> To: David Lechner <dlechner@baylibre.com>
> To: Nuno Sá <nuno.sa@analog.com>
> To: Andy Shevchenko <andy@kernel.org>
> To: Rob Herring <robh@kernel.org>
> To: Krzysztof Kozlowski <krzk+dt@kernel.org>
> To: Conor Dooley <conor+dt@kernel.org>
> To: Nikita Travkin <nikita@trvn.ru>
> To: Maslov Dmitry <maslovdmitry@seeed.cc>
> To: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
> To: Thomas Gleixner <tglx@kernel.org>
> To: Pan Chuang <panchuang@vivo.com>
> To: Yangtao Li <frank.li@vivo.com>
> Cc: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> Cc: linux-iio@vger.kernel.org
> Cc: devicetree@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
>
> ---
> Esben Haabendal (8):
> dt-bindings: iio: light: ltr501: Sort compatible enum array
> dt-bindings: iio: light: ltr501: Add missing ltr303 compatible
> dt-bindings: iio: light: ltr501: Add ltr329 compatible
> iio: light: ltr501: Power down chip if request irq fails
> iio: light: ltr501: Drop duplicated error message
> iio: light: ltr501: Add ltr329 driver support
> iio: light: ltr501: Fix sorting order of device arrays
> dt-bindings: iio: light: ltr501: Make proximity-near-level conditional
>
> .../bindings/iio/light/liteon,ltr501.yaml | 32 +++++-
> drivers/iio/light/ltr501.c | 114 +++++++++++++--------
> 2 files changed, 101 insertions(+), 45 deletions(-)
> ---
> base-commit: 075b74841bd0065a3bda3440873c747938e69b68
> change-id: 20260711-liteon-ltr329-a3eb12414866
>
> Best regards,
> --
> Esben Haabendal <esben@geanix.com>
>
prev parent reply other threads:[~2026-08-22 23:40 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-17 17:08 [PATCH v5 0/8] iio: light: ltr501: Add ltr329 support Esben Haabendal
2026-08-17 17:08 ` [PATCH v5 1/8] dt-bindings: iio: light: ltr501: Sort compatible enum array Esben Haabendal
2026-08-17 17:08 ` [PATCH v5 2/8] dt-bindings: iio: light: ltr501: Add missing ltr303 compatible Esben Haabendal
2026-08-17 17:08 ` [PATCH v5 3/8] dt-bindings: iio: light: ltr501: Add ltr329 compatible Esben Haabendal
2026-08-17 17:08 ` [PATCH v5 4/8] iio: light: ltr501: Power down chip if request irq fails Esben Haabendal
2026-08-17 17:18 ` sashiko-bot
2026-08-22 23:38 ` Jonathan Cameron
2026-08-17 17:08 ` [PATCH v5 5/8] iio: light: ltr501: Drop duplicated error message Esben Haabendal
2026-08-22 23:39 ` Jonathan Cameron
2026-08-17 17:08 ` [PATCH v5 6/8] iio: light: ltr501: Add ltr329 driver support Esben Haabendal
2026-08-17 17:08 ` [PATCH v5 7/8] iio: light: ltr501: Fix sorting order of device arrays Esben Haabendal
2026-08-17 17:21 ` sashiko-bot
2026-08-17 17:08 ` [PATCH v5 8/8] dt-bindings: iio: light: ltr501: Make proximity-near-level conditional Esben Haabendal
2026-08-21 7:34 ` Krzysztof Kozlowski
2026-08-22 23:40 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260823004024.015d66bf@jic23-huawei \
--to=jic23@kernel.org \
--cc=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=esben@geanix.com \
--cc=frank.li@vivo.com \
--cc=krzk+dt@kernel.org \
--cc=krzysztof.kozlowski@oss.qualcomm.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maslovdmitry@seeed.cc \
--cc=nikita@trvn.ru \
--cc=nuno.sa@analog.com \
--cc=panchuang@vivo.com \
--cc=robh@kernel.org \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
--cc=stable@vger.kernel.org \
--cc=tglx@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox