Devicetree
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: David Lechner <dlechner@baylibre.com>
Cc: Taha Ed-Dafili <0rayn.dev@gmail.com>,
	Michael.Hennerich@analog.com, andy@kernel.org,
	conor+dt@kernel.org, conor.dooley@microchip.com,
	devicetree@vger.kernel.org, krzk+dt@kernel.org, lars@metafoo.de,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux@analog.com, nuno.sa@analog.com, robh@kernel.org,
	skhan@linuxfoundation.org
Subject: Re: [PATCH v6 1/6] dt-bindings: iio: dac: ad5504: add output-range and missing gpios
Date: Sun, 23 Aug 2026 02:36:13 +0100	[thread overview]
Message-ID: <20260823023613.077ea05d@jic23-huawei> (raw)
In-Reply-To: <c34ed727-9ece-48f4-a7b7-45b0f5f558e3@baylibre.com>

On Sat, 22 Aug 2026 17:37:22 -0500
David Lechner <dlechner@baylibre.com> wrote:

> On 8/22/26 2:36 PM, Taha Ed-Dafili wrote:
> >> This is one that is starting to emerging as a common name, so I would
> >> call it clear-gpios instead to match the same name on chips with a
> >> similar function.  
> > 
> > Worth noting Nuno asked for the opposite in v2 review, specifically
> > to match the datasheet's /CLR pin name:  
> 
> Normally I advocate for matching the pin name too. But there are some common
> things like reset-gpios where we try to always use the same name. This clear
> input seems to be one of those common things.
> 
> > 
> > https://lore.kernel.org/linux-iio/a79296dc96215a579c29c5c9eda464f818f050d6.camel@gmail.com/
> > 
> > Let me know which name you'd prefer given that context, and I'll
> > update it in v7.
> > 
> > Best Regards,
> > Taha Ed-Dafili  
> 
> 
> There is only one binding currently with clr-gpios (adi,ltc2688).

That one is a reset I think. Includes "The control registers are cleared
to default values".  It sort of clears the DAC as the default is 0V
So probably like 3 below.

> 
> And only one with clear-gpios (adi,ad5791). Plus at least two more coming
> soon [1] [2].
ad5701 clr sets it to a user defined value..  If that's left as default it
sets to 0. That does overwrite the dac register (table 9)

ad5529r actually calls it clear on the datasheet. And just sets DAC outputs
to 0 (including the registers)

dac8163 is 0 scale, or mid scale depending on part. Registers written.
> 
> In [3], there is a /CLR pin, but we called it reset-gpios because it also
> resets the control registers.
> 
> I didn't re-check the datasheets on all of these, but hopefully we are being
> consistent.
Other than the one that maybe should have been a reset and isn't :(

They aren't quite the same across parts but close enough perhaps to generalize
the binding with some flexibility in the description.

Jonathan

> 
> [1]: https://lore.kernel.org/linux-iio/20260820-ad5529r-driver-v9-2-ba62e0b2a816@analog.com/
> [2]: https://lore.kernel.org/linux-iio/20260802-dac8163-work-v3-1-3ecc7bc66d0d@gmx.net/
> [3]: https://lore.kernel.org/linux-iio/20240714133000.5866-5-kimseer.paller@analog.com/
> 
> 
> 
> 


  reply	other threads:[~2026-08-23  1:36 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-22  8:56 [PATCH v6 0/6] iio: dac: ad5504: bindings, cleanups, locking, and scale fixes Taha Ed-Dafili
2026-08-22  8:56 ` [PATCH v6 1/6] dt-bindings: iio: dac: ad5504: add output-range and missing gpios Taha Ed-Dafili
2026-08-22 18:20   ` David Lechner
2026-08-22 19:36     ` Taha Ed-Dafili
2026-08-22 22:37       ` David Lechner
2026-08-23  1:36         ` Jonathan Cameron [this message]
2026-08-22  8:56 ` [PATCH v6 2/6] iio: dac: ad5504: Align headers with IWYU principle Taha Ed-Dafili
2026-08-22  8:56 ` [PATCH v6 3/6] iio: dac: ad5504: separate ACPI and DT paths Taha Ed-Dafili
2026-08-22  8:56 ` [PATCH v6 4/6] iio: dac: ad5504: remove legacy platform data support Taha Ed-Dafili
2026-08-22  8:56 ` [PATCH v6 5/6] iio: dac: ad5504: introduce local lock to protect state and spi transfers Taha Ed-Dafili
2026-08-22  8:56 ` [PATCH v6 6/6] iio: dac: ad5504: support scale via output-range-microvolt property Taha Ed-Dafili
2026-08-22  9:10   ` sashiko-bot
2026-08-22 18:24   ` David Lechner
2026-08-22 19:45     ` Taha Ed-Dafili

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260823023613.077ea05d@jic23-huawei \
    --to=jic23@kernel.org \
    --cc=0rayn.dev@gmail.com \
    --cc=Michael.Hennerich@analog.com \
    --cc=andy@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=conor.dooley@microchip.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=krzk+dt@kernel.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@analog.com \
    --cc=nuno.sa@analog.com \
    --cc=robh@kernel.org \
    --cc=skhan@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox