From: Amit Barzilai <amit.barzilai22@gmail.com>
To: javierm@redhat.com, airlied@gmail.com, simona@ffwll.ch,
maarten.lankhorst@linux.intel.com, mripard@kernel.org,
tzimmermann@suse.de, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org
Cc: andriy.shevchenko@intel.com, holofermes@gmail.com,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
dri-devel@lists.freedesktop.org,
Amit Barzilai <amit.barzilai22@gmail.com>
Subject: [PATCH v5 0/6] drm/ssd130x: Add support for the Solomon SSD1351 OLED controller
Date: Sun, 23 Aug 2026 14:19:53 +0300 [thread overview]
Message-ID: <20260823111959.17029-1-amit.barzilai22@gmail.com> (raw)
This series adds support for the Solomon SSD1351, a 128x128 65k-color
RGB OLED controller, to the ssd130x DRM driver:
- Patch 1 adds the device tree binding.
- Patch 2 switches the SSD133X family from RGB332 to RGB565, bringing
65k color to the SSD1331.
- Patches 3 to 5 are preparatory cleanups requested on v3: constify
the ssd130x_write_data() 'values' parameter, convert
ssd130x_spi_id[] to C99 initializers, and reimplement
ssd130x_write_cmd() as a variadic wrapper around
ssd130x_write_cmds() so a single loop remains.
- Patch 6 adds the SSD1351 as a new SSD135X_FAMILY. It gets its own
primary plane update/disable, encoder enable and backlight
callbacks; only the callbacks with no family-specific logic
(ssd133x_primary_plane_atomic_check(), ssd133x_crtc_atomic_check()
and ssd130x_encoder_atomic_disable()) are reused as is. It also
sends command parameters on the data path, handled in
ssd130x_write_cmds() via a new cmd_params_are_data flag; see [2]
for why the split lives there rather than in the SPI transport.
Testing:
- Patches 1, 3, 4, 5 and 6 are tested on an SSD1351.
- The SSD1331 RGB565 change (patch 2) was kindly tested by Javier on
his SSD1331.
Thanks to Javier, Andy, Krzysztof and Fabio for the reviews.
[1] v4 of this series:
https://lore.kernel.org/dri-devel/20260818080626.30430-1-amit.barzilai22@gmail.com
[2] Command parameter path discussion:
https://lore.kernel.org/dri-devel/20260811122603.30773-1-amit.barzilai22@gmail.com
---
Changes since v4:
- Move assignment of fi and plane_state to be just before their
first use.
- Move ret variable declaration below cmds[] in ssd135x_init().
- Constify remap variable in ssd133x_init() and ssd135x_init().
- Replace ARRAY_SIZE() with sizeof() in ssd130x_write_cmd().
- Collect Andy's Reviewed-by tags on patches 3 and 4.
Amit Barzilai (6):
dt-bindings: display: Add Solomon SSD1351 OLED controller
drm/ssd130x: Change SSD133X color format to RGB565 from RGB332
drm/ssd130x: Constify ssd130x_write_data() 'values' parameter
drm/ssd130x: Replace positional ssd130x_spi_id[] initialization with
C99
drm/ssd130x: Implement ssd130x_write_cmd() on top of
ssd130x_write_cmds()
drm/ssd130x: Add SSD135X_FAMILY and SSD1351 support
.../bindings/display/solomon,ssd1351.yaml | 42 ++
drivers/gpu/drm/solomon/ssd130x-spi.c | 25 +-
drivers/gpu/drm/solomon/ssd130x.c | 420 +++++++++++++++---
drivers/gpu/drm/solomon/ssd130x.h | 10 +-
4 files changed, 432 insertions(+), 65 deletions(-)
create mode 100644 Documentation/devicetree/bindings/display/solomon,ssd1351.yaml
base-commit: 843bc34db94bff0612c8294861b156489958897b
--
2.55.0
next reply other threads:[~2026-08-23 11:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-23 11:19 Amit Barzilai [this message]
2026-08-23 11:19 ` [PATCH v5 1/6] dt-bindings: display: Add Solomon SSD1351 OLED controller Amit Barzilai
2026-08-23 11:28 ` sashiko-bot
2026-08-23 11:19 ` [PATCH v5 2/6] drm/ssd130x: Change SSD133X color format to RGB565 from RGB332 Amit Barzilai
2026-08-23 11:36 ` sashiko-bot
2026-08-24 15:22 ` Andy Shevchenko
2026-08-23 11:19 ` [PATCH v5 3/6] drm/ssd130x: Constify ssd130x_write_data() 'values' parameter Amit Barzilai
2026-08-23 11:19 ` [PATCH v5 4/6] drm/ssd130x: Replace positional ssd130x_spi_id[] initialization with C99 Amit Barzilai
2026-08-23 11:19 ` [PATCH v5 5/6] drm/ssd130x: Implement ssd130x_write_cmd() on top of ssd130x_write_cmds() Amit Barzilai
2026-08-23 11:19 ` [PATCH v5 6/6] drm/ssd130x: Add SSD135X_FAMILY and SSD1351 support Amit Barzilai
2026-08-23 11:34 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260823111959.17029-1-amit.barzilai22@gmail.com \
--to=amit.barzilai22@gmail.com \
--cc=airlied@gmail.com \
--cc=andriy.shevchenko@intel.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=holofermes@gmail.com \
--cc=javierm@redhat.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=robh@kernel.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox