Re: [PATCH v41 1/7] Documentation/firmware: add imx/se to other_interfaces

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Minor grammatical and spacing errors make the text less readable.
--

--- Patch [1]: [PATCH v41 1/7] Documentation/firmware: add imx/se to other_interfaces ---
commit 260e585f488d10326488a8cd35371c3b01d9bec6
Author: Pankaj Gupta <pankaj.gupta@nxp.com>

Documentation/firmware: add imx/se to other_interfaces

This commit documents the i.MX SoC Service layer and character device driver
for secure enclaves like the NXP EdgeLock Enclave.

> diff --git a/Documentation/driver-api/firmware/other_interfaces.rst b/Documentation/driver-api/firmware/other_interfaces.rst
> index 06ac89adaafba..6c6fa9a0ba1df 100644
> --- a/Documentation/driver-api/firmware/other_interfaces.rst
> +++ b/Documentation/driver-api/firmware/other_interfaces.rst
[ ... ]
> +Each of the above features is enabled through dedicated NXP H/W IP on the SoC.
> +On a single SoC, multiple hardware IP (or can say more than one secure enclave)
> +can exist.
> +
> +NXP SoCs enabled with the such secure enclaves(SEs) IPs are:

[Severity: Low]
This isn't a bug, but there is an extra "the" and a missing space before
"(SEs)". Could this be updated to "with such secure enclaves (SEs) IPs are:"?

> +i.MX93, i.MX8ULP
> +
> +To communicate with one or more co-existing SE(s) on SoC, there is/are dedicated
> +messaging units(MU) per SE. Each co-existing SE can have one or multiple exclusive

[Severity: Low]
This isn't a bug, but there is a missing space before "(MU)".

> +MUs, dedicated to itself. None of the MU is shared between two SEs. Communication
[ ... ]
> +NXP Secure Enclave(SE) Interface
> +--------------------------------
> +MU(s) is/are not shared between SE(s). But for an SoC like i.MX95 which has
> +multiple SE(s) like HSM, V2X-HSM, V2X-SHE, all the SE(s) and their interfaces 'se-if'
> +that is/are dedicated to a particular SE will be enumerated and provisioned using the
> +single compatible node("fsl,imx95-se").

[Severity: Low]
This isn't a bug, but there is a missing space before the parenthesis for the
compatible node name.

> +
> +Each 'se-if' comprises two layers:
[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260824-imx-se-if-v41-0-29cf129e4d86@nxp.com?part=1