Re: [PATCH v1 1/3] dt-bindings: rtc: add ricoh,r2223x binding

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The `#clock-cells` property is missing from the `required` list for a device that acts as a clock provider.
--

--- Patch [1]: [PATCH v1 1/3] dt-bindings: rtc: add ricoh,r2223x binding ---
commit 650ba92edebadde8c761f1e4168721297f6edde4
Author: Heiko Schocher <hs@nabladev.com>

dt-bindings: rtc: add ricoh,r2223x binding

This commit introduces a new device tree binding for the Ricoh R2223x
Real-Time Clock. It adds schema definitions for its compatible string,
clock provider capabilities, and an eco mode property.

> diff --git a/Documentation/devicetree/bindings/rtc/ricoh,r2223x.yaml b/Documentation/devicetree/bindings/rtc/ricoh,r2223x.yaml
> new file mode 100644
> index 0000000000000..e64a1ee378e64
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/rtc/ricoh,r2223x.yaml
[ ... ]
> +  start-year: true
> +
> +required:
> +  - compatible
> +  - reg

[Severity: Medium]
Since this device acts as a clock provider and defines #clock-cells above,
should #clock-cells be explicitly included in this required list?

Without it, device tree nodes that omit the property could silently pass
schema validation, potentially leading to runtime failures in dependent
drivers attempting to use the clock functionality.

> +
> +additionalProperties: false

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260824110452.4038870-1-hs@nabladev.com?part=1